Extensions: propagate attributes on type parameters #80032
Conversation
jcouv
added
Area-Compilers
Feature - Extension Everything
jcouv
force-pushed
the
extensions-typeparams
branch
from
368c5b3 to
376f445
Compare
jcouv
changed the title
| } | ||
|
|
||
| [Theory, CombinatorialData] | ||
| public void PropagateAttributes_13(bool useCompilationReference) |
There was a problem hiding this comment.
Is it worth adding indexer tests now, marked skipped until we implement? #Resolved
| int ordinal = 0; | ||
| foreach (var tp in oldTypeParameters) | ||
| { | ||
| var newTp = synthesized ? |
There was a problem hiding this comment.
Is the comment above for when synthesized is true still accurate? It doesn't seem to include extension type parameters. #Resolved
| } | ||
| } | ||
|
|
||
| public class AAttribute : System.Attribute { } |
| 01 00 00 00 | ||
| ) | ||
| .param type T | ||
| .custom instance void AAttribute::.ctor() = ( |
There was a problem hiding this comment.
What's the reason for preserving all attributes? Why wouldn't we preserve just the ones marked with CompilerLoweringPreserve? #Resolved
There was a problem hiding this comment.
The reason for including the attribute here is portability from classic extension methods. We want to produce exactly the same metadata that we did in classic form
I think this extends to adjacent scenarios, such as a static extension method, even though we're not bound by precedent
jcouv
force-pushed
the
extensions-typeparams
branch
from
8013b59 to
1cd0f0d
Compare
4 participants
Addresses part of #78963 ("Metadata: copying attributes (synthesized attributes like nullability? we copy some attributes from enclosing method to closure type, [...])")
Relates to test plan #76130
Relates to #73920