-
Notifications
You must be signed in to change notification settings - Fork 4.2k
ResxSourceGenerator: Added XML comment summary to the generated classes and properties to avoid warning CS1591 if they are public #79940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rties to avoid warning CS1591 if they are public tests: updated unit test resources accordingly to the change
@dotnet-policy-service agree company="uhb Software" |
| {{memberIndent}}/// Overrides the current thread's CurrentUICulture property for all | ||
| {{memberIndent}}/// resource lookups using this strongly typed resource class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this should be using <see cref> for these, but since this is just the existing text from the other generators I'm OK with leaving this.
If the classes generated by the ResxSourceGenerator are public, the warning CS1591 has been emitted, since the XML comments were missing.
Fixes dotnet/roslyn-analyzers#7478
This is the replacement for dotnet/roslyn-analyzers#7366 since the ResxSourceGenerator have been moved to this repository.