Skip to content

Conversation

@jjonescz
Copy link
Member

Fixes #79146.

@jjonescz jjonescz marked this pull request as ready for review August 12, 2025 15:57
@jjonescz jjonescz requested review from a team as code owners August 12, 2025 15:57
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@jjonescz jjonescz requested a review from a team August 13, 2025 07:41
@jjonescz
Copy link
Member Author

@dotnet/roslyn-compiler for a second review, thanks

@jjonescz jjonescz merged commit cdc829e into dotnet:main Aug 14, 2025
29 checks passed
@jjonescz jjonescz deleted the 79146-InvalidScript branch August 14, 2025 17:22
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 14, 2025
333fred added a commit to 333fred/roslyn that referenced this pull request Aug 19, 2025
* upstream/main: (275 commits)
  Update yml files to use community branch (dotnet#79950)
  [main] Source code updates from dotnet/dotnet (dotnet#79920)
  Allow MEF components to supply assembly path resolvers (dotnet#79218)
  update auto merge config (dotnet#79949)
  Update PublishData.json (dotnet#79946)
  Add comment
  Add vb tests
  VB side
  Fix results streamed by ForAttributeWithMetadataName with multiple parts
  chore: deleted accitenly committed local file.
  bugfix: generated the format methods as public as it is with the related properties. tests: updated resources accordingly to the changes.
  Revert "Sneak in a sneaky test IVT"
  Revert "Missed one"
  Missed one
  Sneak in a sneaky test IVT
  Export the analyzer loader for the Misc workspace so the Razor generator has a consistent ALC
  Update localization branch to 17.14
  Reorder checks to report issue as early as possible
  Avoid crash from Script class instantiation (dotnet#79879)
  Unblock type forwarding scenarios involving extensions (dotnet#79905)
  ...
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Requesting classification of Script with SourceCodeKind.Script as the parse kind

4 participants