Disable incremental binary analysis to workaround duplicate VSSetup artifacts #79839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
changed the title
jasonmalinowski
approved these changes
Aug 8, 2025
Member
|
@dibarbet Should we be removing the other workaround? |
JoeRobich
approved these changes
Aug 8, 2025
Member
Author
yes, I'll do that |
dibarbet
added a commit
to dotnet/roslyn-tools
that referenced
this pull request
Aug 11, 2025
…1496) See dotnet/roslyn#79839 for context - the hardlink names have changed and we have a workaround on the roslyn side instead
Member
Author
|
/backport to release/dev17.14 |
Contributor
|
Started backporting to release/dev17.14: https://github.com/dotnet/roslyn/actions/runs/16946707609 |
2 tasks
dibarbet
added a commit
that referenced
this pull request
Aug 13, 2025
…duplicate VSSetup artifacts (#79897) Backport of #79839 to release/dev17.14 /cc @dibarbet ## Customer Impact ## Regression - [ ] Yes - [ ] No [If yes, specify when the regression was introduced. Provide the PR or commit if known.] ## Testing [How was the fix verified? How was the issue missed previously? What tests were added?] ## Risk [High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
This was referenced Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously I made dotnet/roslyn-tools#1494 to workaround an issue with guardian duplicating a bunch of folders in our VSSetup pipeline artifacts.
However, the artifacts they generate have changed their name, so using the workaround they suggested instead. This fixes the VS insertion PR merge diff again.
Validation running here - https://dnceng.visualstudio.com/internal/_build/results?buildId=2767413&view=results
Prior run with the broken artifacts:
