EnC: Mark deleted members with an attribute #79764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
3 tasks
Member
Author
|
@DustinCampbell @phil-allen-msft @dotnet/roslyn-compiler ptal |
tmat
changed the title
333fred
approved these changes
Aug 12, 2025
Member
Author
|
Actually, just realized this might cause undesired behavior in some cases. Following up... |
Member
Author
|
@333fred ptal again. I have reverted the rename and replaced it with emitting an attribute. See description. |
tmat
changed the title
Member
|
@dotnet/roslyn-compiler PTAL |
DustinCampbell
approved these changes
Aug 26, 2025
src/Compilers/Core/Portable/Emit/EditAndContinue/DeletedSourceEventDefinition.cs
Outdated
Show resolved
Hide resolved
src/Compilers/Core/Portable/Emit/EditAndContinue/DeletedSourceEventDefinition.cs
Outdated
Show resolved
Hide resolved
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Aug 26, 2025
|
|
||
| System_Runtime_CompilerServices_HotReloadException__ctorStringInt32, | ||
| System_Runtime_CompilerServices_MetadataUpdateOriginalTypeAttribute__ctor, | ||
| System_Runtime_CompilerServices_MetadataUpdateDeletedAttribute__ctor, |
Member
There was a problem hiding this comment.
Are we aiming to add the BCL type in .NET 10 or did we miss the window? At least, we should get the API design proposal approved before .NET 10 ships
Member
There was a problem hiding this comment.
My question was about timing. Talked to Jeff Handley just now and it looks like there's still a window to add APIs in .NET 10 (RC2 code complete late September). Sounds like he's the area owner, so he'll follow-up with Tomas to get this through API review.
jcouv
reviewed
Aug 26, 2025
src/Compilers/Core/Portable/Emit/EditAndContinue/DeletedSourcePropertyDefinition.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Aug 26, 2025
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Aug 26, 2025
jcouv
reviewed
Aug 26, 2025
src/Compilers/Core/Portable/Emit/EditAndContinue/DeletedSourceEventDefinition.cs
Show resolved
Hide resolved
jcouv
reviewed
Aug 26, 2025
jcouv
reviewed
Aug 26, 2025
jcouv
reviewed
Aug 26, 2025
src/Compilers/Core/Portable/Emit/EditAndContinue/DefinitionMap.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Aug 26, 2025
src/Test/PdbUtilities/EditAndContinue/EditAndContinueTest.GenerationVerifier.cs
Show resolved
Hide resolved
jcouv
reviewed
Aug 26, 2025
src/Test/PdbUtilities/EditAndContinue/EditAndContinueTest.GenerationVerifier.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Aug 26, 2025
src/Compilers/CSharp/Test/Emit2/Emit/EditAndContinue/EditAndContinueTests.cs
Show resolved
Hide resolved
jcouv
reviewed
Aug 26, 2025
Member
jcouv
left a comment
jcouv
left a comment
There was a problem hiding this comment.
Done with review pass (commit 4)
333fred
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefixes the name of deleted methods, properties and events withdeleted_and sets their SpecialName flag to true.This will allow Reflection to filter out deleted members.
Contributes to dotnet/runtime#75154
Implements #69834
UPDATE:
Just realized that renaming the method is not desirable for public methods. If we rename method
Mtodeleted_ManyMemberReftoken that refers toMfrom outside of the assembly will fail to resolve when JIT compiles the caller. That will throwMissingMethodException, which is not what we want. We want the deleted method to be called and its body throwsHotReloadException.Instead we emit
System.Runtime.CompilerServices.MetadataUpdateDeletedAttributeon the deleted member, if the attribute is defined.[jcouv:] API proposal for MetadataUpdateDeletedAttribute