Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 65 additions & 0 deletions src/Features/CSharpTest/EditAndContinue/ActiveStatementTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,71 @@ static void Main(string[] args)
edits.VerifySemanticDiagnostics(active);
}

[Fact]
public void Update_TopLevel()
{
var src1 = """
<AS:0>F();</AS:0>
Map(1, () => 1);
""";

var src2 = """
<AS:0>F();</AS:0>
Map(2, () => 1);
""";

var active = GetActiveStatements(src1, src2);
var edits = GetTopEdits(src1, src2);

edits.VerifySemanticDiagnostics(active);
}

[Fact]
public void Update_TopLevel_ActiveStatementInLambda()
{
var src1 = """
Map(1, () => <AS:0>1</AS:0>);
""";

var src2 = """
Map(2, () => <AS:0>1</AS:0>);
""";

var active = GetActiveStatements(src1, src2);
var edits = GetTopEdits(src1, src2);

edits.VerifySemanticDiagnostics(active,
Diagnostic(RudeEditKind.UpdateMightNotHaveAnyEffect, "2", GetResource("top-level code")));
}

[Fact]
public void Update_RestartRequiredAttribute()
{
var src1 = RestartRequiredOnMetadataUpdateAttributeSrc + """
public class C
{
[RestartRequiredOnMetadataUpdateAttribute]
public int F()
=> <AS:0>1</AS:0>;
}

""";

var src2 = RestartRequiredOnMetadataUpdateAttributeSrc + """
public class C
{
[RestartRequiredOnMetadataUpdateAttribute]
public int F()
=> <AS:0>2</AS:0>;
}
""";

var active = GetActiveStatements(src1, src2);
var edits = GetTopEdits(src1, src2);

edits.VerifySemanticDiagnostics(active);
}

#endregion

#region Delete in Method Body
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1275,8 +1275,8 @@ private void AnalyzeChangedMemberBody(

// Updating an entry point, a method marked with RestartRequiredOnMetadataUpdateAttribute,
// a static constructor or a static member with an initializer will most likely have no effect,
// unless the update is in a lambda body.
if (IsRestartRequired(oldMember, oldDeclaration, oldModel.Compilation, newMember, newDeclaration, cancellationToken))
// unless the update is in a lambda body or the member body is an active frame.
if (!bodyHasActiveStatement && IsRestartRequired(oldMember, oldDeclaration, oldModel.Compilation, newMember, newDeclaration, cancellationToken))
{
var oldTokens = oldMemberBody?.GetUserCodeTokens(DescendantTokensIgnoringLambdaBodies) ?? [];
var newTokens = newMemberBody?.GetUserCodeTokens(DescendantTokensIgnoringLambdaBodies) ?? [];
Expand Down
Loading