Move fix all helpers to shared location so that CodeStyle can reference them #79736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
force-pushed
the
sharedFixAllCode
branch
from
2ba16f3 to
e308cb1
Compare
JoeRobich
reviewed
Aug 1, 2025
| // Note: We avoid fixing diagnostics in generated code. | ||
| if (document != null && !await document.IsGeneratedCodeAsync(cancellationToken).ConfigureAwait(false)) | ||
| { | ||
| #if WORKSPACE |
Member
There was a problem hiding this comment.
Should we advertise in some way that this helper will not work for these scopes from the code style layer? DocComment and Debug.Assert perhaps?
Member
Author
There was a problem hiding this comment.
so, practically, it's a non issue. Here's why:
- we changed it so that we do NOT use the code-style analyzers/fixers ourselves within VS. Jared updated things so we always use what we shipped in box.
- So this only affects code style analyzers/fixers run by other tools that are pulling that in (like
dotnet format). Those tools are not doing fix-all in that scoped fashion ('in correct type', etc).
I'm happy to comment and add asserts. I have a followup pr i can put that in if that works for you.
Member
Author
There was a problem hiding this comment.
JoeRobich
approved these changes
Aug 1, 2025
Open
3 tasks
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.