Delay MatchesContainingTypeParameters check for extensions loaded from metadata #79588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m metadata Doing this check while loading types might get compiler into a cycle.
AlekseyTs
added
Area-Compilers
Feature - Extension Everything
jcouv
reviewed
Jul 24, 2025
| if (marker.TryGetExtensionMarkerMethod() is { IsNil: false } markerHandle) | ||
| { | ||
| marker = PENamedTypeSymbol.Create(moduleSymbol, this, markerRid, type.Handle, markerHandle); | ||
| marker = PENamedTypeSymbol.Create(moduleSymbol, this, markerRid, marker, markerHandle); |
Member
There was a problem hiding this comment.
nit: it didn't catch my eye in earlier PR, but it's strange to assign this to marker. A fresh local, maybe named "extension", would be better. I'm happy to do this tweak later on (just let me know if okay)
Contributor
Author
|
@jjonescz, @dotnet/roslyn-compiler For a second review |
jjonescz
approved these changes
Jul 25, 2025
This was referenced Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this check while loading types might get compiler into a cycle.
Relates to test plan #76130