Skip to content

Further simplification of common test patterns. #79568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

Further simplification of common test patterns. #79568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d511f98
inline test strings
CyrusNajmabadi Jul 24, 2025
9b3e554
Cleanup test methods
CyrusNajmabadi Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/Analyzers/CSharp/Tests/AddRequiredParentheses/AddRequiredExpressionParenthesesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,9 +427,8 @@ void M()
""", RequireAllParenthesesForClarity);

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/79286")]
public async Task TestCoalescePrecedence4()
{
await TestMissingAsync(
public Task TestCoalescePrecedence4()
=> TestMissingAsync(
"""
class C
{
Expand All @@ -439,7 +438,6 @@ void M()
}
}
""", RequireAllParenthesesForClarity);
}

[Fact]
public Task TestBitwisePrecedence1()
Expand Down
14 changes: 4 additions & 10 deletions src/Analyzers/CSharp/Tests/ImplementInterface/ImplementInterfaceCodeFixTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5369,9 +5369,8 @@ public void Goo(byte x = 1)
""");

[Fact, WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/545736")]
public async Task TestCastedOptionalParameter1()
{
const string code = """
public Task TestCastedOptionalParameter1()
=> TestWithAllCodeStyleOptionsOffAsync("""
using System;
interface I
{
Expand All @@ -5381,9 +5380,7 @@ interface I
class C : {|CS0535:I|}
{
}
""";

const string expected = """
""", """
using System;
interface I
{
Expand All @@ -5397,10 +5394,7 @@ public void Goo(ConsoleColor x = (ConsoleColor)(-1))
throw new NotImplementedException();
}
}
""";

await TestWithAllCodeStyleOptionsOffAsync(code, expected);
}
""");

[Fact, WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/545737")]
public Task TestCastedEnumValue()
Expand Down
Loading
Loading