Prevent auth issue in PR val builds #79524
Conversation
dibarbet
force-pushed
the
dev/dibarbet/pr_val
branch
from
eba600b to
e85d47f
Compare
dibarbet
changed the title
| arguments: "-sourceBranchName $(SourceBranchName) -prNumber ${{ parameters.PRNumber }} -commitSHA ${{ parameters.CommitSHA }} -enforceLatestCommit ${{ iif(parameters.EnforceLatestCommit, '1', '0') }}" | ||
| condition: succeeded() | ||
|
|
||
| - task: Powershell@2 |
There was a problem hiding this comment.
Is the intent that if this fails, at least we already got the PR out for now?
There was a problem hiding this comment.
(maybe add a comment to that effect)
There was a problem hiding this comment.
not sure exactly what you mean - I moved it because in order to get the commit details, we need to have it checked out. I guess I could continue on failure, but I suspect it would fail in followup steps when we try to reset the build number.
This shouldn't fail anymore since its just reading the local git repo and not making a github API request.
| arguments: "-sourceBranchName $(SourceBranchName) -prNumber ${{ parameters.PRNumber }} -commitSHA ${{ parameters.CommitSHA }} -enforceLatestCommit ${{ iif(parameters.EnforceLatestCommit, '1', '0') }}" | ||
| condition: succeeded() | ||
|
|
||
| - task: Powershell@2 |
There was a problem hiding this comment.
(maybe add a comment to that effect)
|
/backport to release/dev17.14 |
|
Started backporting to release/dev17.14: https://github.com/dotnet/roslyn/actions/runs/16891686067 |
Likely other jobs on the machine are causing rate limits. Avoid querying github until we can figure out the correct way to authenticate.