Improve performance of fix all that only changes syntax #79108
Merged
+192
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Jun 23, 2025
...oslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/Core/FixAnalyzers/FixerWithFixAllAnalyzer.cs
Outdated
Show resolved
Hide resolved
…nalyzers/FixerWithFixAllAnalyzer.cs
|
Noticed this while running my new fixer. |
CyrusNajmabadi
commented
Jun 23, 2025
src/EditorFeatures/Core/Suggestions/RefineUsingCopilot/RefineUsingCopilotCodeAction.cs
Outdated
Show resolved
Hide resolved
…singCopilotCodeAction.cs
…oslyn into refactoringPerf
CyrusNajmabadi
commented
Jun 23, 2025
| newSolution = await fixMultipleCodeAction.GetChangedSolutionInternalAsync( | ||
| fixAllState.Solution, progress, postProcessChanges: false, cancellationToken).ConfigureAwait(false); | ||
| fixAllState.Solution, progress, cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
this logic moved into FixMultipleCodeAction
CyrusNajmabadi
force-pushed
the
refactoringPerf
branch
from
bbafac7 to
f772949
Compare
|
@dotnet/roslyn-ide ptal. |
|
@ToddGrun ptal. |
JoeRobich
reviewed
Jun 24, 2025
| Task<CodeAction?> GetFixAsync(IFixAllContext fixAllContext); | ||
|
|
||
| /// <summary> | ||
| /// The sort of cleanup that should automatically be poerformed for this fix all provider. By default this is |
There was a problem hiding this comment.
Suggested change
| /// The sort of cleanup that should automatically be poerformed for this fix all provider. By default this is | |
| /// The sort of cleanup that should automatically be performed for this fix all provider. By default this is |
There was a problem hiding this comment.
can fixup later :)
JoeRobich
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.