Skip to content

Delete unused package references #78958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

Delete unused package references #78958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c38b3ce
Remove now unused Progression references and related hacks
jasonmalinowski Jun 13, 2025
a766830
Remove more unneeded references
jasonmalinowski Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions eng/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,6 @@
<PackageVersion Include="Microsoft.VisualStudio.Extensibility.JsonGenerators.Sdk" Version="17.12.2037-preview3" />
<PackageVersion Include="Microsoft.VSSDK.Debugger.VSDConfigTool" Version="17.13.1100801-preview" />
<PackageVersion Include="Microsoft.VisualStudio.ProjectSystem" Version="17.0.77-pre-g62a6cb5699" />
<PackageVersion Include="Microsoft.VisualStudio.Progression.CodeSchema" Version="15.8.27812-alpha" />
<PackageVersion Include="Microsoft.VisualStudio.Progression.Common" Version="15.8.27812-alpha" />
<PackageVersion Include="Microsoft.VisualStudio.Progression.Interfaces" Version="15.8.27812-alpha" />
<PackageVersion Include="Microsoft.VisualStudio.CallHierarchy.Package.Definitions" Version="15.8.27812-alpha" />
<PackageVersion Include="Microsoft.VisualStudio.CodeAnalysis.Sdk.UI" Version="15.8.27812-alpha" />
<PackageVersion Include="Microsoft.VisualStudio.Language.CallHierarchy" Version="15.8.27812-alpha" />
Expand Down Expand Up @@ -99,14 +96,12 @@
<PackageVersion Include="Microsoft.VisualStudio.CoreUtility" Version="17.13.226" />
<PackageVersion Include="Microsoft.VisualStudio.Editor" Version="17.13.226" />
<PackageVersion Include="Microsoft.VisualStudio.ImageCatalog" Version="17.13.40008" />
<PackageVersion Include="Microsoft.VisualStudio.Imaging.Interop.14.0.DesignTime" Version="17.13.40008" />
<PackageVersion Include="Microsoft.VisualStudio.Language" Version="17.13.226" />
<PackageVersion Include="Microsoft.VisualStudio.Language.NavigateTo.Interfaces" Version="17.13.226" />
<PackageVersion Include="Microsoft.VisualStudio.Language.StandardClassification" Version="17.13.226" />
<PackageVersion Include="Microsoft.VisualStudio.LanguageServer.Client" Version="17.13.33" />
<PackageVersion Include="Microsoft.VisualStudio.RemoteControl" Version="16.3.52" />
<PackageVersion Include="Microsoft.VisualStudio.RpcContracts" Version="17.13.7" />
<PackageVersion Include="Microsoft.VisualStudio.Shell.15.0" Version="17.13.40008" />
<PackageVersion Include="Microsoft.VisualStudio.Telemetry" Version="17.14.8" />
<PackageVersion Include="Microsoft.VisualStudio.Text.Data" Version="17.13.226" />
<PackageVersion Include="Microsoft.VisualStudio.Text.Logic" Version="17.13.226" />
Expand Down
3 changes: 0 additions & 3 deletions eng/config/globalconfigs/Common.globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,6 @@ dotnet_diagnostic.VSTHRD010.severity = none
# VSTHRD110: Observe result of async calls
dotnet_diagnostic.VSTHRD110.severity = none

# Workaround for old Microsoft.VisualStudio.Progression.* packages: https://github.com/dotnet/roslyn/issues/71404
dotnet_diagnostic.VSIXCompatibility1001.severity = none

dotnet_diagnostic.HAA0101.severity = none
dotnet_diagnostic.HAA0102.severity = none
dotnet_diagnostic.HAA0201.severity = none
Expand Down
3 changes: 0 additions & 3 deletions eng/targets/Settings.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@

<VSSDKTargetPlatformRegRootSuffix>RoslynDev</VSSDKTargetPlatformRegRootSuffix>

<!-- Workaround for old Microsoft.VisualStudio.Progression.* packages -->
<NoWarn>$(NoWarn);VSIXCompatibility1001</NoWarn>

<!-- TODO: https://github.com/dotnet/roslyn/issues/71667 -->
<NoWarn>$(NoWarn);NU1507</NoWarn>

Expand Down
1 change: 0 additions & 1 deletion src/Compilers/Test/Core/Traits/Traits.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ public static class Features
public const string Packaging = nameof(Packaging);
public const string PasteTracking = nameof(PasteTracking);
public const string Peek = nameof(Peek);
public const string Progression = nameof(Progression);
public const string ProjectSystemShims = nameof(ProjectSystemShims);
public const string SarifErrorLogging = nameof(SarifErrorLogging);
public const string QuickInfo = nameof(QuickInfo);
Expand Down
3 changes: 0 additions & 3 deletions src/VisualStudio/Core/Def/Microsoft.VisualStudio.LanguageServices.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,6 @@
<PackageReference Include="Microsoft.VisualStudio.Debugger.Engine-implementation" />
<PackageReference Include="Microsoft.VisualStudio.Sdk" />
<PackageReference Include="Microsoft.VisualStudio.Search" />
<PackageReference Include="Microsoft.VisualStudio.Progression.CodeSchema" />
<PackageReference Include="Microsoft.VisualStudio.Progression.Common" />
<PackageReference Include="Microsoft.VisualStudio.Progression.Interfaces" />
<PackageReference Include="Microsoft.VisualStudio.CallHierarchy.Package.Definitions" />
<PackageReference Include="Microsoft.VisualStudio.Language.CallHierarchy" />
<PackageReference Include="Microsoft.VisualStudio.VsInteractiveWindow" />
Expand Down
6 changes: 0 additions & 6 deletions src/VisualStudio/Core/Test/Microsoft.VisualStudio.LanguageServices.UnitTests.vbproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,7 @@
<InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.CSharp.UnitTests" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.Elfie" />
<PackageReference Include="Microsoft.VisualStudio.InteractiveWindow" />
<PackageReference Include="Xunit.Combinatorial" PrivateAssets="all" />

<!-- This is needed by the Progression and Graph Model APIs at runtime -->
<PackageReference Include="Microsoft.VisualStudio.Diagnostics.Measurement" NoWarn="NU1605" IncludeAssets="runtime" />
<PackageReference Include="Microsoft.VisualStudio.Diagnostics.PerformanceProvider" IncludeAssets="runtime" />
</ItemGroup>
<ItemGroup>
<Import Include="System.Threading.Tasks" />
Expand Down
4 changes: 0 additions & 4 deletions src/VisualStudio/LiveShare/Impl/Microsoft.VisualStudio.LanguageServices.LiveShare.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,11 @@
<CreateVsixContainer>false</CreateVsixContainer>
</PropertyGroup>
<ItemGroup Label="Project References">
<ProjectReference Include="..\..\..\EditorFeatures\CSharp\Microsoft.CodeAnalysis.CSharp.EditorFeatures.csproj" />
<ProjectReference Include="..\..\..\EditorFeatures\VisualBasic\Microsoft.CodeAnalysis.VisualBasic.EditorFeatures.vbproj" />
<ProjectReference Include="..\..\..\LanguageServer\Protocol\Microsoft.CodeAnalysis.LanguageServer.Protocol.csproj" />
<ProjectReference Include="..\..\Core\Def\Microsoft.VisualStudio.LanguageServices.csproj" />
</ItemGroup>
<ItemGroup>
<!-- Override versions used by LiveShare packages. -->
<PackageReference Include="Microsoft.VisualStudio.Shell.15.0" />
<PackageReference Include="Microsoft.VisualStudio.Imaging.Interop.14.0.DesignTime" />

<PackageReference Include="Microsoft.VisualStudio.LiveShare" />
<PackageReference Include="Microsoft.VisualStudio.LiveShare.LanguageServices" />
Expand Down