Skip to content

Add VSTypeScriptAsynchronousTaggerProvider2 for TypeScript that avoids TemporaryArray #78866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025
Merged

Add VSTypeScriptAsynchronousTaggerProvider2 for TypeScript that avoids TemporaryArray #78866

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afc18e1
Add VSTypeScriptAsynchronousTaggerProvider2 for TypeScript that avoid…
tmat Jun 9, 2025
e5a5375
Pool
tmat Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions ...orFeatures/Core/ExternalAccess/VSTypeScript/Api/VSTypeScriptAsynchronousTaggerProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,18 @@
// See the LICENSE file in the project root for more information.

using System;
using System.Collections.Generic;
using Microsoft.CodeAnalysis.Editor.Tagging;
using Microsoft.CodeAnalysis.PooledObjects;
using Microsoft.CodeAnalysis.Shared.Collections;
using Microsoft.CodeAnalysis.Shared.TestHooks;
using Microsoft.VisualStudio.Text;
using Microsoft.VisualStudio.Text.Editor;
using Microsoft.VisualStudio.Text.Tagging;

namespace Microsoft.CodeAnalysis.ExternalAccess.VSTypeScript.Api;

// TODO: remove
internal abstract class VSTypeScriptAsynchronousTaggerProvider<TTag> : AsynchronousViewTaggerProvider<TTag>
where TTag : ITag
{
Expand All @@ -23,3 +29,30 @@ protected VSTypeScriptAsynchronousTaggerProvider(VSTypeScriptTaggerHost taggerHo
{
}
}

internal abstract class VSTypeScriptAsynchronousTaggerProvider2<TTag> : AsynchronousViewTaggerProvider<TTag>
where TTag : ITag
{
protected VSTypeScriptAsynchronousTaggerProvider2(VSTypeScriptTaggerHost taggerHost)
: base(taggerHost.UnderlyingObject, FeatureAttribute.Classification)
{
}

protected sealed override bool TryAddSpansToTag(ITextView? textView, ITextBuffer subjectBuffer, ref TemporaryArray<SnapshotSpan> result)
{
using var _ = ArrayBuilder<SnapshotSpan>.GetInstance(out var builder);
if (TryAddSpansToTagImpl(textView, subjectBuffer, builder))
{
foreach (var item in builder)
{
result.Add(item);
}

return true;
}

return false;
}

protected abstract bool TryAddSpansToTagImpl(ITextView? textView, ITextBuffer subjectBuffer, ICollection<SnapshotSpan> result);
}
Loading