Skip to content

Add IsNull property to IAsyncToken #78718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged

Add IsNull property to IAsyncToken #78718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abb875d
Add IsNull property to IAsyncToken and use it instead of checking for…
tmat May 27, 2025
96e9a56
Fix
tmat May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Dependencies/Threading/TestHooks/IAsyncToken.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ namespace Microsoft.CodeAnalysis.Shared.TestHooks;

internal interface IAsyncToken : IDisposable
{
bool IsNull { get; }
}
3 changes: 3 additions & 0 deletions src/Workspaces/Core/Portable/Shared/TestHooks/AsynchronousOperationListener+AsyncToken.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ public AsyncToken(AsynchronousOperationListener listener)

public AsynchronousOperationListener Listener { get; }

public bool IsNull
=> false;

public void Dispose()
{
using (Listener._gate.DisposableWait(CancellationToken.None))
Expand Down
2 changes: 2 additions & 0 deletions src/Workspaces/Core/Portable/Shared/TestHooks/EmptyAsyncToken.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ internal sealed class EmptyAsyncToken : IAsyncToken
{
public static IAsyncToken Instance { get; } = new EmptyAsyncToken();

public bool IsNull => true;

private EmptyAsyncToken()
{
}
Expand Down
2 changes: 1 addition & 1 deletion src/Workspaces/Core/Portable/Shared/TestHooks/TaskExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public static Task CompletesAsyncOperation(this Task task, IAsyncToken asyncToke
[SuppressMessage("Style", "VSTHRD200:Use \"Async\" suffix for async methods", Justification = "This is a Task wrapper, not an asynchronous method.")]
public static Task CompletesTrackingOperation(this Task task, IDisposable token)
{
if (token == null || token == EmptyAsyncToken.Instance)
if (token is IAsyncToken { IsNull: true })
{
return task;
}
Expand Down