Skip to content

Update ICSharpCode.Decompiler to 9.1.0.7988 #78270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

Update ICSharpCode.Decompiler to 9.1.0.7988 #78270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71fee60
Update ICSharpCode.Decompiler to 9.1.0.7988
christophwille Apr 23, 2025
e5c12ca
IAssemblyResolver now uses MetadataFile instead of PEFile in signatures
christophwille Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@
<PackageVersion Include="SQLitePCLRaw.provider.e_sqlite3.net45" Version="$(SqliteVersion)" />

<PackageVersion Include="Humanizer.Core" Version="$(HumanizerVersion)" />
<PackageVersion Include="ICSharpCode.Decompiler" Version="8.2.0.7535" />
<PackageVersion Include="ICSharpCode.Decompiler" Version="9.1.0.7988" />
<PackageVersion Include="Microsoft.CodeAnalysis.Elfie" Version="1.0.0" />

<!--
Expand Down
2 changes: 1 addition & 1 deletion src/EditorFeatures/Test/MetadataAsSource/AbstractMetadataAsSourceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ namespace Microsoft.CodeAnalysis.Editor.UnitTests.MetadataAsSource;
[UseExportProvider]
public abstract partial class AbstractMetadataAsSourceTests : IAsyncLifetime
{
protected static readonly string ICSharpCodeDecompilerVersion = "8.2.0.7535";
protected static readonly string ICSharpCodeDecompilerVersion = "9.1.0.7988";

public virtual Task InitializeAsync()
{
Expand Down
8 changes: 4 additions & 4 deletions src/LanguageServer/Protocol/Features/DecompiledSource/AssemblyResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@ void BuildReferenceCache()
}
}

public Task<PEFile> ResolveAsync(IAssemblyReference name)
public Task<MetadataFile> ResolveAsync(IAssemblyReference name)
{
return Task.FromResult(Resolve(name));
}

public Task<PEFile> ResolveModuleAsync(PEFile mainModule, string moduleName)
public Task<MetadataFile> ResolveModuleAsync(MetadataFile mainModule, string moduleName)
{
return Task.FromResult(ResolveModule(mainModule, moduleName));
}
Expand All @@ -70,7 +70,7 @@ public PEFile TryResolve(MetadataReference metadataReference, PEStreamOptions st
return null;
}

public PEFile Resolve(IAssemblyReference name)
public MetadataFile Resolve(IAssemblyReference name)
{
Log("------------------");
Log(FeaturesResources.Resolve_0, name.FullName);
Expand Down Expand Up @@ -147,7 +147,7 @@ PEFile MakePEFile(IAssemblySymbol assembly)
}
}

public PEFile ResolveModule(PEFile mainModule, string moduleName)
public MetadataFile ResolveModule(MetadataFile mainModule, string moduleName)
{
Log("-------------");
Log(FeaturesResources.Resolve_module_0_of_1, moduleName, mainModule.FullName);
Expand Down