Convert SyntaxNode.GetText users to instead retrieve the source text from the document #78259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce text from the document This is currently a draft mode PR until I can get back vs insertion speedometer numbers that corroborate the improvements I think this will have. If that happens, I will elevate the PR out of draft mode and add the before/after performance characteristics.
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
approved these changes
Apr 22, 2025
ToddGrun
changed the title
This was referenced Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some of the SyntaxNode.GetText callers that were calling this on a root node, and instead switch them over to use Document.GetValueTextAsync instead. Each SyntaxNode.GetText call builds up a new SourceText from scratch. Instead, if Document.GetValueTextAsync is used, there is the potential for sharing the sourcetext with other document consumers.
This shows up as about a 50MB allocation improvement in VS under AbstractMemberInsertingCompletionProvider.RemoveDestinationNodeAsync in the override completion commit scenario in the C# editing speedometer.