Reduce allocations in NamespaceSymbol.GetExtensionContainers #78243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ordered Going to create a test insertion to get numbers before moving out of draft mode. Will add performance justification of the change at that point.
ghost
added
Area-Compilers
untriaged
…ontainers virtual and having MergedNamespaceSymbol implement it directly.
ToddGrun
changed the title
Contributor
Author
|
@dotnet/roslyn-compiler -- This is ready for review |
ToddGrun
changed the title
AlekseyTs
reviewed
Apr 23, 2025
|
|
||
| protected void AddExtensionContainersForType(NamedTypeSymbol type, ArrayBuilder<NamedTypeSymbol> extensions) | ||
| { | ||
| if (!type.IsReferenceType || !type.IsStatic || type.IsGenericType || !type.MightContainExtensionMethods) return; |
Contributor
Contributor
Author
There was a problem hiding this comment.
That's not an obvious equivalence (for me, at least). I'd prefer not to make that change, but will if you would like me to.
Contributor
There was a problem hiding this comment.
Consider at least adding a comment capturing the suggestion and starting with // Tracked by https://github.com/dotnet/roslyn/issues/76130 :
AlekseyTs
reviewed
Apr 23, 2025
| } | ||
| } | ||
|
|
||
| protected void AddExtensionContainersForType(NamedTypeSymbol type, ArrayBuilder<NamedTypeSymbol> extensions) |
Contributor
There was a problem hiding this comment.
"AddExtensionContainersFromType" or "AddExtensionContainersInType"? #Closed
333fred
approved these changes
Apr 23, 2025
This was referenced Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce allocations from executing NamespaceSymbol.GetExtensionContainers. This method accounts for 48% of allocations in our CodeAnalysis process during completion in our C# editing speedometer test. The changes in this PR reduce that to about 4.5%
The change here is to add an override of NamespaceSymbol.GetExtensionContainers to MergedNamespaceSymbol. Specifically, the base class implementation of GetExtensionContainers calls GetTypeMembersUnordered, which is inefficient when in a MergedNamespaceSymbol instance as it does a Linq OfType call and allocates an IA from that. Instead, the new override can just enumerate over the result of GetMembersUnordered directly, and do the check before calling into shared code with the base implementation.
*** Previous allocations during completion section of C# editing speedometer test ***
*** New allocations in NamespaceSymbol.GetTypeMembersUnordered ***
*** New allocations in MergedNamespaceSymbol.GetTypeMembersUnordered ***
