Skip to content

Conversation

@bernd5
Copy link
Contributor

@bernd5 bernd5 commented Apr 21, 2025

fixes #78222

Add missing handling for extension type symbols in variance safety check...

@bernd5 bernd5 requested a review from a team as a code owner April 21, 2025 12:54
@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 21, 2025
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Apr 21, 2025
@AlekseyTs
Copy link
Contributor

Done with review pass (commit 3)

@AlekseyTs AlekseyTs requested review from a team, jcouv and jjonescz April 22, 2025 14:09
@AlekseyTs AlekseyTs added the Feature - Extension Everything The extension everything feature label Apr 22, 2025
@jcouv jcouv self-assigned this Apr 22, 2025
@bernd5 bernd5 requested a review from AlekseyTs April 23, 2025 13:09
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 5)

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 5)

@jcouv jcouv merged commit dd09372 into dotnet:main Apr 23, 2025
24 checks passed
@jcouv
Copy link
Member

jcouv commented Apr 23, 2025

Merged/squashed. Thanks for the contribution @bernd5 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Feature - Extension Everything The extension everything feature untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiler crash when attempting to define extension inside interface type

5 participants