Skip to content

Unseal LSP types #78041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 8, 2025
Merged

Unseal LSP types #78041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a1d6105
Removed sealed from lsp types
Apr 7, 2025
6f81ae0
FileOperations comments
Apr 8, 2025
d44761f
InlineValues comments
Apr 8, 2025
fc95858
Moniker comments
Apr 8, 2025
61bcbe7
Navigation comments
Apr 8, 2025
46ca8c7
Notebook comments
Apr 8, 2025
62f4b50
SemanticTokens comments
Apr 8, 2025
68dbe9d
Protocol comments
Apr 8, 2025
0b5e826
Internal comments
Apr 8, 2025
8204eba
Undo changes
Apr 8, 2025
4846b7c
Unseal types razor derives from
Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/LanguageServer/Protocol/Protocol/ColorPresentationParams.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ namespace Roslyn.LanguageServer.Protocol;
/// </para>
/// </summary>
/// <remarks>Since LSP 3.6</remarks>
internal sealed class ColorPresentationParams : ITextDocumentParams, IWorkDoneProgressParams, IPartialResultParams<ColorPresentation[]>
/// <remarks>Do not seal this type! This is extended by Razor</remarks>
internal class ColorPresentationParams : ITextDocumentParams, IWorkDoneProgressParams, IPartialResultParams<ColorPresentation[]>
{
/// <summary>
/// The text document.
Expand Down
3 changes: 2 additions & 1 deletion src/LanguageServer/Protocol/Protocol/DocumentColorParams.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ namespace Roslyn.LanguageServer.Protocol;
/// </para>
/// </summary>
/// <remarks>Since LSP 3.6</remarks>
internal sealed class DocumentColorParams : ITextDocumentParams, IWorkDoneProgressParams, IPartialResultParams<ColorInformation[]>
/// <remarks>Do not seal this type! This is extended by Razor</remarks>
internal class DocumentColorParams : ITextDocumentParams, IWorkDoneProgressParams, IPartialResultParams<ColorInformation[]>
{
/// <summary>
/// The <see cref="TextDocumentIdentifier"/> to provide color information for.
Expand Down
3 changes: 2 additions & 1 deletion src/LanguageServer/Protocol/Protocol/DocumentFormattingParams.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ namespace Roslyn.LanguageServer.Protocol;
/// See the <see href="https://microsoft.github.io/language-server-protocol/specifications/specification-current/#documentFormattingParams">Language Server Protocol specification</see> for additional information.
/// </para>
/// </summary>
internal sealed class DocumentFormattingParams : ITextDocumentParams, IWorkDoneProgressParams
/// <remarks>Do not seal this type! This is extended by Razor</remarks>
internal class DocumentFormattingParams : ITextDocumentParams, IWorkDoneProgressParams
{
/// <summary>
/// Gets or sets the identifier for the text document to be formatted.
Expand Down
3 changes: 2 additions & 1 deletion src/LanguageServer/Protocol/Protocol/DocumentOnTypeFormattingParams.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ namespace Roslyn.LanguageServer.Protocol;
/// See the <see href="https://microsoft.github.io/language-server-protocol/specifications/specification-current/#documentOnTypeFormattingParams">Language Server Protocol specification</see> for additional information.
/// </para>
/// </summary>
internal sealed class DocumentOnTypeFormattingParams : ITextDocumentPositionParams
/// <remarks>Do not seal this type! This is extended by Razor</remarks>
internal class DocumentOnTypeFormattingParams : ITextDocumentPositionParams
{
/// <summary>
/// The document to format.
Expand Down
3 changes: 2 additions & 1 deletion src/LanguageServer/Protocol/Protocol/FoldingRangeParams.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ namespace Roslyn.LanguageServer.Protocol;
/// </para>
/// </summary>
/// <remarks>Since LSP 3.17</remarks>
internal sealed class FoldingRangeParams : ITextDocumentParams, IWorkDoneProgressParams, IPartialResultParams<FoldingRange[]>
/// <remarks>Do not seal this type! This is extended by Razor</remarks>
internal class FoldingRangeParams : ITextDocumentParams, IWorkDoneProgressParams, IPartialResultParams<FoldingRange[]>
{
/// <summary>
/// Gets or sets the text document associated with the folding range request.
Expand Down
3 changes: 2 additions & 1 deletion src/LanguageServer/Protocol/Protocol/Internal/VSInternalCodeAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ namespace Roslyn.LanguageServer.Protocol;
/// <summary>
/// Class used to extend <see cref="CodeAction" /> to add the data field for codeAction/_ms_resolve support.
/// </summary>
internal sealed class VSInternalCodeAction : CodeAction
/// <remarks>Do not seal this type! This is extended by Razor</remarks>
internal class VSInternalCodeAction : CodeAction
{
/// <summary>
/// Gets or sets the group this CodeAction belongs to.
Expand Down
3 changes: 2 additions & 1 deletion src/LanguageServer/Protocol/Protocol/Internal/VSInternalInlineCompletionRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ namespace Roslyn.LanguageServer.Protocol;
///
/// See https://github.com/microsoft/vscode/blob/075ba020e8493f40dba89891b1a08453f2c067e9/src/vscode-dts/vscode.proposed.inlineCompletions.d.ts#L24.
/// </summary>
internal sealed class VSInternalInlineCompletionRequest : ITextDocumentParams
/// <remarks>Do not seal this type! This is extended by Razor</remarks>
internal class VSInternalInlineCompletionRequest : ITextDocumentParams
{
/// <summary>
/// Gets or sets the text document.
Expand Down
3 changes: 2 additions & 1 deletion src/LanguageServer/Protocol/Protocol/Internal/VSInternalTextPresentationParams.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ namespace Roslyn.LanguageServer.Protocol;
/// <summary>
/// Class representing the parameters sent for a textDocument/_vs_textPresentation request.
/// </summary>
internal sealed class VSInternalTextPresentationParams : ITextDocumentParams
/// <remarks>Do not seal this type! This is extended by Razor</remarks>
internal class VSInternalTextPresentationParams : ITextDocumentParams
{
/// <summary>
/// Gets or sets the identifier for the text document to be operate on.
Expand Down
3 changes: 2 additions & 1 deletion src/LanguageServer/Protocol/Protocol/Internal/VSInternalUriPresentationParams.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ namespace Roslyn.LanguageServer.Protocol;
/// <summary>
/// Class representing the parameters sent for a textDocument/_vs_uriPresentation request.
/// </summary>
internal sealed class VSInternalUriPresentationParams : ITextDocumentParams
/// <remarks>Do not seal this type! This is extended by Razor</remarks>
internal class VSInternalUriPresentationParams : ITextDocumentParams
{
/// <summary>
/// Gets or sets the identifier for the text document to be operate on.
Expand Down
3 changes: 2 additions & 1 deletion src/LanguageServer/Protocol/Protocol/Internal/VSInternalValidateBreakableRangeParams.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ namespace Roslyn.LanguageServer.Protocol;
/// <summary>
/// Class representing the parameters sent for the textDocument/validateBreakableRange request.
/// </summary>
internal sealed class VSInternalValidateBreakableRangeParams : ITextDocumentParams
/// <remarks>Do not seal this type! This is extended by Razor</remarks>
internal class VSInternalValidateBreakableRangeParams : ITextDocumentParams
{
/// <summary>
/// Gets or sets the <see cref="TextDocumentIdentifier"/> for the request.
Expand Down
3 changes: 2 additions & 1 deletion src/LanguageServer/Protocol/Protocol/SemanticTokens/SemanticTokensRangeParams.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ namespace Roslyn.LanguageServer.Protocol;
/// </para>
/// </summary>
/// <remarks>Since LSP 3.16</remarks>
internal sealed class SemanticTokensRangeParams : ITextDocumentParams, IWorkDoneProgressParams, IPartialResultParams<SemanticTokensPartialResult>
/// <remarks>Do not seal this type! This is extended by Razor</remarks>
internal class SemanticTokensRangeParams : ITextDocumentParams, IWorkDoneProgressParams, IPartialResultParams<SemanticTokensPartialResult>
{
/// <summary>
/// Gets or sets an identifier for the document to fetch semantic tokens from.
Expand Down
12 changes: 0 additions & 12 deletions src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/RulesMissingDocumentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ RS1018 | | DiagnosticId for analyzers must be in specified format |
RS1019 | | DiagnosticId must be unique across analyzers |
RS1020 | | Category for analyzers must be from the specified values |
RS1021 | | Invalid entry in analyzer category and diagnostic ID range specification file |
RS1022 | <https://github.com/dotnet/roslyn/blob/main/docs/roslyn-analyzers/rules/RS1022.md> | Do not use types from Workspaces assembly in an analyzer |
RS1024 | | Symbols should be compared for equality |
RS1025 | | Configure generated code analysis |
RS1026 | | Enable concurrent execution |
Expand All @@ -38,18 +37,7 @@ RS1034 | | Prefer 'IsKind' for checking syntax kinds |
RS1035 | | Do not use APIs banned for analyzers |
RS1036 | | Specify analyzer banned API enforcement setting |
RS1037 | | Add "CompilationEnd" custom tag to compilation end diagnostic descriptor |
RS1038 | <https://github.com/dotnet/roslyn/blob/main/docs/roslyn-analyzers/rules/RS1038.md> | Compiler extensions should be implemented in assemblies with compiler-provided references |
RS1039 | | This call to 'SemanticModel.GetDeclaredSymbol()' will always return 'null' |
RS1040 | | This call to 'SemanticModel.GetDeclaredSymbol()' will always return 'null' |
RS1041 | <https://github.com/dotnet/roslyn/blob/main/docs/roslyn-analyzers/rules/RS1041.md> | Compiler extensions should be implemented in assemblies targeting netstandard2.0 |
RS1042 | | Implementations of this interface are not allowed |
RS1043 | | Do not use file types for implementing analyzers, generators, and code fixers |
RS2000 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Add analyzer diagnostic IDs to analyzer release |
RS2001 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Ensure up-to-date entry for analyzer diagnostic IDs are added to analyzer release |
RS2002 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Do not add removed analyzer diagnostic IDs to unshipped analyzer release |
RS2003 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Shipped diagnostic IDs that are no longer reported should have an entry in the 'Removed Rules' table in unshipped file |
RS2004 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Diagnostic IDs marked as removed in analyzer release file should not be reported by analyzers |
RS2005 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Remove duplicate entries for diagnostic ID in the same analyzer release |
RS2006 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Remove duplicate entries for diagnostic ID between analyzer releases |
RS2007 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Invalid entry in analyzer release file |
RS2008 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md> | Enable analyzer release tracking |
2 changes: 0 additions & 2 deletions ...nalyzers/Microsoft.CodeAnalysis.BannedApiAnalyzers/RulesMissingDocumentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,4 @@

Rule ID | Missing Help Link | Title |
--------|-------------------|-------|
RS0030 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.BannedApiAnalyzers/BannedApiAnalyzers.Help.md> | Do not use banned APIs |
Copy link
Contributor Author

@ryzngard ryzngard Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume I should revert these files? I didn't manually change them

Copy link
Contributor Author

@ryzngard ryzngard Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoeRobich do you know? IIRC you had this in your PR too

Copy link
Member

@JoeRobich JoeRobich Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are automatically generated during the build. You are fine to merge them. Sorry it is noisy.

RS0031 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.BannedApiAnalyzers/BannedApiAnalyzers.Help.md> | The list of banned symbols contains a duplicate |
RS0035 | | External access to internal symbols outside the restricted namespace(s) is prohibited |
19 changes: 0 additions & 19 deletions src/RoslynAnalyzers/PublicApiAnalyzers/RulesMissingDocumentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,3 @@

Rule ID | Missing Help Link | Title |
--------|-------------------|-------|
RS0016 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Add public types and members to the declared API |
RS0017 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Remove deleted types and members from the declared API |
RS0022 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Constructor make noninheritable base class inheritable |
RS0024 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | The contents of the public API files are invalid |
RS0025 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Do not duplicate symbols in public API files |
RS0036 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Annotate nullability of public types and members in the declared API |
RS0037 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Enable tracking of nullability of reference types in the declared API |
RS0041 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Public members should not use oblivious types |
RS0048 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Missing shipped or unshipped public API file |
RS0050 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | API is marked as removed but it exists in source code |
RS0051 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Add internal types and members to the declared API |
RS0052 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Remove deleted types and members from the declared internal API |
RS0053 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | The contents of the internal API files are invalid |
RS0054 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Do not duplicate symbols in internal API files |
RS0055 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Annotate nullability of internal types and members in the declared API |
RS0056 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Enable tracking of nullability of reference types in the declared API |
RS0057 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Internal members should not use oblivious types |
RS0058 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Missing shipped or unshipped internal API file |
RS0061 | <https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md> | Constructor make noninheritable base class inheritable |
Loading