Adds 💡 Implement Using Copilot for NotImplementedException
#77299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icate-for-features
src/Features/CSharp/Portable/Copilot/CSharpImplementNotImplementedExceptionFixProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/Copilot/CSharpImplementNotImplementedExceptionFixProvider.cs
Show resolved
Hide resolved
src/Features/CSharp/Portable/Copilot/CSharpImplementNotImplementedExceptionFixProvider.cs
Outdated
Show resolved
Hide resolved
...pTest/Copilot/CSharpImplementNotImplementedExceptionFixProviderTests.CodeBlockSuggestions.cs
Show resolved
Hide resolved
src/Features/ExternalAccess/Copilot/GenerateImplementation/ImplementationDetailsWrapper.cs
Outdated
Show resolved
Hide resolved
| ImmutableDictionary<SyntaxNode, ImmutableArray<ReferencedSymbol>> methodOrProperties, | ||
| CancellationToken cancellationToken) | ||
| { | ||
| if (GenerateImplementationService is null) |
There was a problem hiding this comment.
This bit makes it clear that GenerateImplemenationService shouldn't be declared as nullable. Why are null checks needed for fields that have been proven non-null in the constructor?
There was a problem hiding this comment.
So, it is totally possible for the service to be null, and that is when the the EA layer API that I am adding is not yet available to the copilot service. in that case, this will be null. The reason for null checks in ctor I believe is to report when this unwanted state is present. that's why I mentioned the dual insertion, when the newer roslyn package gets ingested by copilot service then this service will no longer be null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offers 💡
Implement Using CopilotwhenNotImplementedExceptionis present in code.FixAll_Faster.mp4