Skip to content

Do not offer to use expression body on a lambda if it would cause overload resolution to change. #76646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 7, 2025
Merged

Do not offer to use expression body on a lambda if it would cause overload resolution to change. #76646

merged 3 commits into from
Jan 7, 2025

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Jan 6, 2025

Fixes #76645

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner January 6, 2025 23:18
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 6, 2025
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Jan 7, 2025

@JoeRobich @akhera99 ptal.

@build-analysis build-analysis bot mentioned this pull request Jan 7, 2025
Closed
3 tasks
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Jan 7, 2025

@davidwengier ptal. yes, i'm pinging you because i assume australians are awake any time the US is asleep :)

@davidwengier
Copy link
Member

davidwengier commented Jan 7, 2025

Sure, but do I want to set a precedent?

@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Jan 7, 2025

Sure, but do I want to set a precedent?

I think connects are coming up soon. So... YES!

@CyrusNajmabadi CyrusNajmabadi merged commit 78075d8 into dotnet:main Jan 7, 2025
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the lambdaOverloadResolution branch January 7, 2025 06:11
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jan 7, 2025
This was referenced Jan 14, 2025
Closed
Closed
Closed
This was referenced Jan 23, 2025
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.14 P1 Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidwengier davidwengier davidwengier approved these changes

@JoeRobich JoeRobich Awaiting requested review from JoeRobich

@ToddGrun ToddGrun Awaiting requested review from ToddGrun

@akhera99 akhera99 Awaiting requested review from akhera99

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Milestone

17.14 P1

Development

Successfully merging this pull request may close these issues.

IDE0053 suggested change results in stack overflow

3 participants

@CyrusNajmabadi @davidwengier @dibarbet