Release a SeparatedSyntaxListBuilder back to the SyntaxListPool #76635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this when looking at the SyntaxListPool and that it's allocated debug info was not reducing back to zero. The early return codepaths earlier in the method are commonly hit avoiding the current code from releasing "variables" back into the pool. Changed to account for the early returns by utilizing the existing finally block similar to what is done for the "mods" pooled item.
ghost
added
Area-Compilers
untriaged
RikkiGibson
approved these changes
Jan 7, 2025
Contributor
Author
|
@dotnet/roslyn-compiler for 2nd review |
chsienki
approved these changes
Jan 7, 2025
This was referenced Jan 14, 2025
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when looking at the SyntaxListPool and that it's _allocated debug info was not reducing back to zero length.
The early return codepaths in LanguageParser.ParseLocalDeclarationStatement are commonly hit, preventing the current code from releasing "variables" back into the pool. Changed to account for the early returns by utilizing the existing finally block similar to what is done for the "mods" pooled item.