Indent expressions when converting to object initializer #76334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
Member
Author
|
@JoeRobich @ToddGrun ptal |
JoeRobich
reviewed
Dec 9, 2024
|
|
||
| protected TExpressionSyntax Indent(TExpressionSyntax expression, IndentationOptions indentationOptions) | ||
| { | ||
| var insertionText = indentationOptions.FormattingOptions.UseTabs |
Member
There was a problem hiding this comment.
So, perhaps my mental model of UseTab, TabSize, and IndentSize are wrong, but I thought that the indentation was always IndentSize spaces wide and that could use 1 or more tabs based on TabSize.
UseTabs = true
TabSize = 2
IndentSize = 4
each indent would be \t\t.
UseTabs = false
TabSize = 2
IndentSize = 4
each indent would be \s\s\s\s.
Member
Author
There was a problem hiding this comment.
you are correct. this doesn't properly implement the desired indentation logic. I will fixup. Nice catch.
JoeRobich
approved these changes
Dec 9, 2024
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46665