Skip to content

Attempt to reuse 'nameof' expressions in attributes when converting from a local function to a method #76325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CyrusNajmabadi merged 3 commits into from
Dec 9, 2024
Merged

Attempt to reuse 'nameof' expressions in attributes when converting from a local function to a method #76325

CyrusNajmabadi merged 3 commits into from
Dec 9, 2024

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Dec 7, 2024

Fixes #64904

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner December 7, 2024 21:22
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 7, 2024
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Dec 7, 2024

@ToddGrun @JoeRobich ptal

ToddGrun
ToddGrun reviewed Dec 9, 2024
View reviewed changes
src/Features/CSharpTest/ConvertLocalFunctionToMethod/ConvertLocalFunctionToMethodTests.cs
{
void M()
{
void [||]M2([A(nameof(b), P = nameof(b))] string b)
Copy link
Contributor

@ToddGrun ToddGrun Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A(nameof(b), P = nameof(b

would it be worth testing that it doesn't use nameof for something for P in the following?

void M2([A(nameof(b), P = "b")] string b)

Copy link
Member Author

@CyrusNajmabadi CyrusNajmabadi Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah :)

and basically i dont' care. the chance of the user writing that seems miniscule.

Copy link
Contributor

@ToddGrun ToddGrun Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey dokey!

ToddGrun
ToddGrun approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 665ef18 into dotnet:main Dec 9, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the convertLocalNameof branch December 9, 2024 18:41
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 9, 2024
This was referenced Dec 12, 2024
Closed
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

@JoeRobich JoeRobich Awaiting requested review from JoeRobich

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Milestone

17.13 P3

Development

Successfully merging this pull request may close these issues.

"Convert to method": nameof expression in attributes is converted to string literal

3 participants

@CyrusNajmabadi @ToddGrun @dibarbet