Skip to content

Do not format nodes when only changing their namespace name. #76294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CyrusNajmabadi merged 24 commits into from
Dec 7, 2024
Merged

Do not format nodes when only changing their namespace name. #76294

CyrusNajmabadi merged 24 commits into from
Dec 7, 2024

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Dec 6, 2024

Fixes #54889

@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners December 6, 2024 05:03
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 6, 2024
@CyrusNajmabadi CyrusNajmabadi changed the title Do not format nodes when changing their namespace. Do not format nodes when only changing their namespace name. Dec 6, 2024
@CyrusNajmabadi CyrusNajmabadi requested review from ToddGrun and removed request for a team December 6, 2024 23:03
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Dec 6, 2024

@ToddGrun ptal

@CyrusNajmabadi CyrusNajmabadi merged commit 5ab0f18 into dotnet:main Dec 7, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the moveTypeFormatting branch December 7, 2024 00:25
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 7, 2024
This was referenced Dec 12, 2024
Closed
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

@ToddGrun ToddGrun Awaiting requested review from ToddGrun

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Milestone

17.13 P3

Development

Successfully merging this pull request may close these issues.

Move to namespace screws up document formatting

3 participants

@CyrusNajmabadi @JoeRobich @dibarbet