Skip to content

Fix go-to-def on an abstract explicit impl of an interface method #76238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CyrusNajmabadi merged 5 commits into from
Dec 6, 2024
Merged

Fix go-to-def on an abstract explicit impl of an interface method #76238

CyrusNajmabadi merged 5 commits into from
Dec 6, 2024

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Dec 3, 2024

Fixes #61268

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner December 3, 2024 18:34
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 3, 2024
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Dec 6, 2024

@ToddGrun ptal

ToddGrun
ToddGrun reviewed Dec 6, 2024
View reviewed changes
src/EditorFeatures/CSharpTest/CodeActions/ImplementInterface/ImplementImplicitlyTests.cs
{
await TestMissingAsync(
"""
await TestInRegularAndScriptAsync("""
Copy link
Contributor

@ToddGrun ToddGrun Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestInRegularAndScriptAsync

nit: test name should probably change

Copy link
Member Author

@CyrusNajmabadi CyrusNajmabadi Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Well fix in follow-up. The original tray was just validating no crash. The actual behavior is fine either way.

ToddGrun
ToddGrun approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit e6a3bd7 into dotnet:main Dec 6, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the gotodefAbstractExplicit branch December 6, 2024 05:16
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 6, 2024
This was referenced Dec 12, 2024
Closed
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Milestone

17.13 P3

Development

Successfully merging this pull request may close these issues.

"Go To Definition" on re-abstraction doesn't go the re-abstracted member

3 participants

@CyrusNajmabadi @ToddGrun @dibarbet