Skip to content

Fix override implementation with generics and constraints #76223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CyrusNajmabadi merged 1 commit into from
Dec 3, 2024
Merged

Fix override implementation with generics and constraints #76223

CyrusNajmabadi merged 1 commit into from
Dec 3, 2024

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Dec 2, 2024

Fixes #71225

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner December 2, 2024 06:44
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 2, 2024
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Dec 2, 2024
Closed
ToddGrun
ToddGrun approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 85e537a into dotnet:main Dec 3, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the overrideConstraints branch December 3, 2024 20:21
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 3, 2024
This was referenced Dec 12, 2024
Closed
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

@akhera99 akhera99 Awaiting requested review from akhera99

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Milestone

17.13 P3

Development

Successfully merging this pull request may close these issues.

"Implement abstract class" should add the right generic constraint when a parameter is covariant in T? and constrained to be a subtype

3 participants

@CyrusNajmabadi @ToddGrun @dibarbet