Improve parsing recovery with 'file' keyword #76185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Compilers
untriaged
Member
Author
|
@dotnet/roslyn-compiler @RikkiGibson ptal. |
jaredpar
added
Feature - File-Local Types
Member
Author
|
@dotnet/roslyn-compiler @RikkiGibson ptal. Thanks! |
CyrusNajmabadi
commented
Dec 3, 2024
| while (true) | ||
| { | ||
| if (this.CurrentToken.Kind == SyntaxKind.OpenBraceToken || | ||
| ((_termState & TerminatorState.IsEndOfRecordOrClassOrStructOrInterfaceSignature) != 0 && this.CurrentToken.Kind == SyntaxKind.SemicolonToken) || |
Member
Author
There was a problem hiding this comment.
_termState check was unnecessary. Assert and comment added at start of method to explain why.
3 tasks
RikkiGibson
reviewed
Dec 4, 2024
| { | ||
| UsingTree(""" | ||
| class C : B | ||
| file class D |
Member
There was a problem hiding this comment.
I imagine a similar, more contrived case may also be positively impacted
class Outer
{
class C : B
required int Prop { get; set; }
}but, don't find it interesting enough to ask you to come back and add the test.
RikkiGibson
approved these changes
Dec 4, 2024
Member
Author
|
@dotnet/roslyn-compiler for a second pair of eyes on this simple pr :) Thanks! |
333fred
approved these changes
Dec 5, 2024
Member
Author
|
Thanks! |
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75992