Skip to content

Insert parens when hitting semicolon after 'new' #76152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CyrusNajmabadi merged 2 commits into from
Dec 2, 2024
Merged

Insert parens when hitting semicolon after 'new' #76152

CyrusNajmabadi merged 2 commits into from
Dec 2, 2024

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Nov 29, 2024

Fixes #54213

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 29, 2024 08:49
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 29, 2024
ToddGrun
ToddGrun reviewed Dec 2, 2024
View reviewed changes
src/EditorFeatures/CSharp/CompleteStatement/CompleteStatementCommandHandler.cs
if (!speculative)
{
var edit = args.SubjectBuffer.CreateEdit();
edit.Insert(caret, "();");
Copy link
Contributor

@ToddGrun ToddGrun Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit.Insert(caret, "();");

Is adding the class name for the new operator an option that can be specified?

Copy link
Contributor

@ToddGrun ToddGrun Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted offline, didn't consider that scenario important enough unless there is customer feedgack.

ToddGrun
ToddGrun approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 92c2860 into dotnet:main Dec 2, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the newCompletion branch December 2, 2024 21:02
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 2, 2024
@dotnet-bot dotnet-bot mentioned this pull request Dec 4, 2024
Closed
This was referenced Dec 11, 2024
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.13 P3

Development

Successfully merging this pull request may close these issues.

Method call completion for "new" expression when the created object's type is already known.

3 participants

@CyrusNajmabadi @ToddGrun @dibarbet