Skip to content

Do a better job matching properties to implement against existing properties #76144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2024
Merged

Do a better job matching properties to implement against existing properties #76144

merged 1 commit into from
Dec 2, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #19721

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 29, 2024 03:15
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 29, 2024
ToddGrun
ToddGrun reviewed Dec 2, 2024
View reviewed changes
src/Analyzers/Core/CodeFixes/ImplementInterface/ImplementInterfaceGenerator.cs
if (!SignatureComparer.Instance.HaveSameSignatureAndConstraintsAndReturnType(existingMember, memberToAdd, IsCaseSensitive))
return false;

if (existingMember is IPropertySymbol existingProperty && memberToAdd is IPropertySymbol propertyToAdd)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (existingMember is IPropertySymbol existingProperty && memberToAdd is IPropertySymbol propertyToAdd)

Coffee still isn't hitting, doesn't SignatureComparer.HaveSameSignatureAndConstraintsAndReturnType now cover this case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline

ToddGrun
ToddGrun approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit dd4ff9c into dotnet:main Dec 2, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the implInterfaceAccessors branch December 2, 2024 17:05
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 2, 2024
@dotnet-bot dotnet-bot mentioned this pull request Dec 4, 2024
Closed
This was referenced Dec 11, 2024
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P3
Development

Successfully merging this pull request may close these issues.

Implement Interface adds uneeded members when implementing interface with new methods
3 participants
@CyrusNajmabadi @ToddGrun @dibarbet