Add a dedicated fixer to fixup code in expression trees that is now calling restricted apis #76124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alling restricted apis
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Nov 27, 2024
3 tasks
ToddGrun
reviewed
Dec 2, 2024
...es/UseExplicitArrayInExpressionTree/CSharpUseExplicitArrayInExpressionTreeCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Dec 2, 2024
...es/UseExplicitArrayInExpressionTree/CSharpUseExplicitArrayInExpressionTreeCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Dec 2, 2024
| var originalParameter = originalMethod.Parameters[i]; | ||
| var currentParameter = currentMethod.Parameters[i]; | ||
|
|
||
| // Different parameter types, look for another sibling that matches |
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74030
This was a request from the LDM for users who run into cases where their expression trees no longer compile because the compiler now picks an overload of the method they were calling that is not legal to use in an expression tree. For example, switching to a
params ReadOnlySpan<...>method from aparams T[]method.The fixer switches the code to use explicit types to ensure this continues working.