Skip to content

Update FindRefs to find constructor references in a primary constructor base type #76097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CyrusNajmabadi merged 2 commits into from
Nov 26, 2024
Merged

Update FindRefs to find constructor references in a primary constructor base type #76097

CyrusNajmabadi merged 2 commits into from
Nov 26, 2024

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Nov 26, 2024

Fixes #73704

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 26, 2024 14:34
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 26, 2024
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Nov 26, 2024

@ToddGrun ptal

ToddGrun
ToddGrun approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 175121c into dotnet:main Nov 26, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 26, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the farPrimaryConstructor branch November 26, 2024 19:57
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Nov 27, 2024
Closed
@dotnet-bot dotnet-bot mentioned this pull request Nov 29, 2024
Closed
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Nov 30, 2024
Closed
@Rekkonnect Rekkonnect mentioned this pull request Nov 30, 2024
Closed
This was referenced Dec 11, 2024
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Jan 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

@dibarbet dibarbet Awaiting requested review from dibarbet

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Milestone

17.13 P3

Development

Successfully merging this pull request may close these issues.

SymbolFinder.FindReferencesAsync not returning references used as base constructor

3 participants

@CyrusNajmabadi @ToddGrun @dibarbet