Use IsManagedType for determining which state machine hoisted locals to clear
#75841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
untriaged
Member
Author
|
@dotnet/roslyn-compiler for second review. Thanks |
cston
approved these changes
Nov 14, 2024
This was referenced Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic previously used
MightContainReferenceswhich is a crude approximation ofIsManagedType.This is in preparation for work on #75666
Relates to recent change (#75426) which is also about conditionally clearing state in managed types to let go of any unnecessary references.
Look at the diff between commit 1 (baseline) and commit 2 (code change) to see the expectedOutput and IL changes.