Support navigating to metadata in progression results #75728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
dibarbet
approved these changes
Nov 5, 2024
| var symbolId = graphNode.GetValue<SymbolKey?>(RoslynGraphProperties.SymbolId); | ||
| private async Task NavigateToAsync(GraphNode graphNode, CancellationToken cancellationToken) | ||
| { | ||
| var projectId = graphNode.GetValue<ProjectId>(RoslynGraphProperties.ContextProjectId); |
There was a problem hiding this comment.
Are there any UI thread requirements for this?
| if (document == null) | ||
| // Go through the mainline symbol id path if we have it. That way we notify third parties, and we can navigate | ||
| // to metadata. | ||
| var symbolId = graphNode.GetValue<SymbolKey?>(RoslynGraphProperties.SymbolId); |
There was a problem hiding this comment.
Do we ever get called for other languages (TS/F#) here?
There was a problem hiding this comment.
looks the same as before, so assumingthis is fine
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7151