Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR feedback on "use collection expression". #75303

Merged
merged 3 commits into from
Oct 1, 2024
Merged

PR feedback on "use collection expression". #75303

merged 3 commits into from
Oct 1, 2024

Conversation

CyrusNajmabadi
Copy link
Member

No description provided.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner September 30, 2024 22:23
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 30, 2024
CyrusNajmabadi
CyrusNajmabadi commented Sep 30, 2024
View reviewed changes
...nalyzers/UseCollectionExpression/CSharpUseCollectionExpressionForFluentDiagnosticAnalyzer.cs
@@ -186,128 +186,119 @@ private static bool AnalyzeInvocation(

var ienumerableOfTType = compilation.IEnumerableOfTType();

using var _1 = ArrayBuilder<ExpressionSyntax>.GetInstance(out var stack);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

view with whitespace off.

ToddGrun
ToddGrun approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 92fcee1 into dotnet:main Oct 1, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the moreFluentCases branch October 1, 2024 18:23
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 1, 2024
This was referenced Oct 9, 2024
Closed
Closed
Closed
@akhera99 akhera99 modified the milestones: Next, 17.13 P1 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P1
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @ToddGrun @akhera99