Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes comparison of VB XML literals #75301

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Fixes comparison of VB XML literals #75301

merged 4 commits into from
Oct 2, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Sep 30, 2024 •
edited
Loading

Fixes #75231, #51374

@tmat tmat requested review from a team as code owners September 30, 2024 21:20
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 30, 2024
@tmat
Copy link
Member Author

tmat commented Sep 30, 2024

@davidwengier @dotnet/roslyn-compiler ptal

AlekseyTs
AlekseyTs approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

@build-analysis build-analysis bot mentioned this pull request Oct 1, 2024
Open
3 tasks
@tmat
Copy link
Member Author

tmat commented Oct 1, 2024

@jaredpar @cston @jjonescz for 2nd review.

@tmat tmat enabled auto-merge (squash) October 2, 2024 02:57
@tmat tmat merged commit 1cd3100 into dotnet:main Oct 2, 2024
28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 2, 2024
@MartyIX
Copy link
Contributor

MartyIX commented Oct 2, 2024 •
edited
Loading

The GitHub syntax is IMO:

Fixes #75231
Fixes #51374

to mark both issues as fixed.

This was referenced Oct 9, 2024
Closed
Closed
Closed
@akhera99 akhera99 modified the milestones: Next, 17.13 P1 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cston cston cston approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P1
Development

Successfully merging this pull request may close these issues.

XML Literal Hot Reload Issue
6 participants
@tmat @MartyIX @davidwengier @AlekseyTs @cston @akhera99