Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Quick Info content production to the Features layer and add Razor EA co-hosting APIs for Hover and Completion #75226

Merged
merged 28 commits into from
Sep 30, 2024
Merged

Move Quick Info content production to the Features layer and add Razor EA co-hosting APIs for Hover and Completion #75226

merged 28 commits into from
Sep 30, 2024

Commits on Sep 24, 2024

  1. Introduce Quick Info presentation model in the Features layer 

    This is necessary to produce rich VS adornment-based hover tooltips in Roslyn OOP. Currently this logic lives in the EditorFeatures layer.
    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c9c3ca7 View commit details
    Browse the repository at this point in the history

  2. Add helpers to convert QuickInfo presentation elements to LSP elements

    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f05390c View commit details
    Browse the repository at this point in the history

  3. Add helpers to convert presentation elements to VS adornments

    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d594024 View commit details
    Browse the repository at this point in the history

  4. Introduce NavigationActionFactory in IntellisenseQuickInfoBuilderContext 

    IntellisenseQuickInfoBuilderContext has four(!) properties that are used to create navigation Actions. I've wrapped this in NavigationActionFactory class.
    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    59b4479 View commit details
    Browse the repository at this point in the history

  5. Move IntellisenseQuickInfoBuilderContext to Features layer and rename 

    IntellisenseQuickInfoBuilderContext renamed to QuickInfoContentBuilderContext
    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b0c46a8 View commit details
    Browse the repository at this point in the history

  6. Rename OnTheFlyDocsElement to OnTheFlyDocsInfo

    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e7c2899 View commit details
    Browse the repository at this point in the history

  7. Move EditorFeaturesOnTheFlyDocsElement to Features layer and rename 

    EditorFeaturesOnTheFlyDocsElement renamed to QuickInfoOnTheFlyDocsElement
    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    888d075 View commit details
    Browse the repository at this point in the history

  8. Move remaining navigation action logic into NavigationActionFactory

    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    912ae5a View commit details
    Browse the repository at this point in the history

  9. Clean up IndentationHelper

    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9a1c3b1 View commit details
    Browse the repository at this point in the history

  10. Rewrite BuildInteractiveTextElements 

    This change is a rewrite of BuildInteractiveTextElements to reduce allocations and prepare it to be moved to the Features layer. In addition, it is no exposed as an extension method on ImmutableArray<TaggedText> named ToInteractiveTextElements(...).
    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b649f1e View commit details
    Browse the repository at this point in the history

  11. Move TaggedTextExtensions to Features layer

    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    030efe6 View commit details
    Browse the repository at this point in the history

  12. Move Quick Info's BuildInteractiveContentAsync to Features layer

    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2cf6fcb View commit details
    Browse the repository at this point in the history

  13. Clean up and reduce allocations in QuickInfoContentBuilder

    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2b0aa54 View commit details
    Browse the repository at this point in the history

  14. Push logic to compute VS image Id from glyphs to Features layer

    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bcac320 View commit details
    Browse the repository at this point in the history

  15. Move helpers that convert to Roslyn LSP elements to language server

    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0f49c9f View commit details
    Browse the repository at this point in the history

  16. Remove ILspHoverResultCreationService 

    With the logic to produce rich Quick Info content in the Features layer, this service is no longer and its logic can be moved into HoverHandler.
    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    581f55c View commit details
    Browse the repository at this point in the history

  17. Remove ILspReferencesResultCreationService

    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0d92e27 View commit details
    Browse the repository at this point in the history

  18. Remove ILspSymbolInformationCreationService

    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a086f84 View commit details
    Browse the repository at this point in the history

  19. Remove ILspCompletionResultCreationService

    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    18c234b View commit details
    Browse the repository at this point in the history

  20. Add GetHoverAsync(...) to ExternalAccess.Razor

    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8901af8 View commit details
    Browse the repository at this point in the history

  21. Add GetCompletionListAsync and ResolveCompletionItemAsync to Razor EA

    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    76c324f View commit details
    Browse the repository at this point in the history

  22. Fix formatting

    @DustinCampbell
    DustinCampbell committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a1fb88d View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Move Glyph.GetVsImageData() extension method to LanguageServer.Protocol 

    Per code review feedback, this extension shouldn't be defined in the Features layer. Instead, it can move to LanguageServer.Protocol and be leveraged from the EditorFeatures layer.
    @DustinCampbell
    DustinCampbell committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    206199f View commit details
    Browse the repository at this point in the history

  2. Return FrozenDictionary from CreateGlyphToElementMap

    @DustinCampbell
    DustinCampbell committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a60dd72 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Update shared handler methods to take IGlobalOptionService

    @DustinCampbell
    DustinCampbell committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    87b859f View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary commented code

    @DustinCampbell
    DustinCampbell committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    51842c9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into razor-cohosting-hover

    @DustinCampbell
    DustinCampbell committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    b7b74aa View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Merge branch 'main' into razor-cohosting-hover

    @DustinCampbell
    DustinCampbell committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    fc5687b View commit details
    Browse the repository at this point in the history