Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yield before performing Go To Definition work #75149

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Yield before performing Go To Definition work #75149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/EditorFeatures/Core/GoToDefinition/GoToDefinitionCommandHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
using Microsoft.VisualStudio.Commanding;
using Microsoft.VisualStudio.Text;
using Microsoft.VisualStudio.Text.Editor.Commanding.Commands;
using Microsoft.VisualStudio.Threading;
using Microsoft.VisualStudio.Utilities;
using Roslyn.Utilities;

Expand Down Expand Up @@ -118,6 +119,10 @@ private async Task ExecuteAsynchronouslyAsync(
{
var cancellationToken = backgroundIndicator.UserCancellationToken;

// Switch to a background thread before continuing. We don't want synchronous work before the first yield to
// prevent the background work indicator from functioning properly.
await TaskScheduler.Default;

// determine the location first.
var definitionLocation = await service.GetDefinitionLocationAsync(
document, position, cancellationToken).ConfigureAwait(false);
Expand Down
Loading