Field-backed properties: support partial properties with auto-implemented accessors and with initializers #74959

cston · 2024-08-30T18:51:35Z

RikkiGibson · 2024-09-06T18:58:12Z

Test failure log

[xUnit.net 00:01:15.29]     Microsoft.CodeAnalysis.CSharp.Semantic.UnitTests.SourceGeneration.GeneratorDriverFuzzTests.Fuzz_Generate [FAIL]
  Failed Microsoft.CodeAnalysis.CSharp.Semantic.UnitTests.SourceGeneration.GeneratorDriverFuzzTests.Fuzz_Generate [2 s]
  Error Message:
   Assert.Equal() Failure
Expected: ImmutableArray<SyntaxTree> []
Actual:   ImmutableArray<SyntaxTree> System.Collections.Immutable.ImmutableArray`1[Microsoft.CodeAnalysis.SyntaxTree]
  Stack Trace:
     at Microsoft.CodeAnalysis.CSharp.Semantic.UnitTests.SourceGeneration.GeneratorDriverFuzzTests.Fuzz_Iteration(Int32 iteration, Random random) in /_/src/Compilers/CSharp/Test/Semantic/SourceGeneration/GeneratorDriverFuzzTests.cs:line 332
   at Microsoft.CodeAnalysis.CSharp.Semantic.UnitTests.SourceGeneration.GeneratorDriverFuzzTests.Fuzz_Generate() in /_/src/Compilers/CSharp/Test/Semantic/SourceGeneration/GeneratorDriverFuzzTests.cs:line 258
  Standard Output Messages:
     [Fact]
     public void Fuzz_782()
     {
         var source = "";
         var comp = CreateCompilation(source);
         var hintNameProvider = new HintNameProvider(4);
         var generator = new IncrementalGeneratorWrapper(new PipelineCallbackGenerator(registerPipeline));
 
         // original input
         var originalInputs = new[]
         {
             new InMemoryAdditionalText("0", "a"),
             new InMemoryAdditionalText("1", "c"),
         };
 
         // from scratch on original
         GeneratorDriver driver1 = CSharpGeneratorDriver.Create(new[] { generator }, originalInputs);
         driver1.RunGenerators(comp);
 
         // make edits to original input
         var editedInputs = ImmutableArray.Create(new AdditionalText[]
         {
             new InMemoryAdditionalText("2", "a"),
             new InMemoryAdditionalText("3", "b"),
             new InMemoryAdditionalText("1", "b"),
         });
 
         // incremental update from edited input
         driver1 = driver1.ReplaceAdditionalTexts(editedInputs);
         hintNameProvider.Reset(4);
         driver1 = driver1.RunGenerators(comp);
         var result1 = driver1.GetRunResult();
 
         // from scratch on edited
         GeneratorDriver driver2 = CSharpGeneratorDriver.Create(new[] { generator }, editedInputs);
         hintNameProvider.Reset(4);
         driver2 = driver2.RunGenerators(comp);
         var result2 = driver2.GetRunResult();
 
         Assert.Equal(result2.GeneratedTrees, result1.GeneratedTrees, SyntaxTreeComparer.Instance);
         Assert.Equal(result2.Diagnostics, result1.Diagnostics, CommonDiagnosticComparer.Instance);
 
         void registerPipeline(IncrementalGeneratorInitializationContext context)
         {
             var provider = context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Select((additionalText, _) => (AdditionalText)new InMemoryAdditionalText(additionalText.Path, additionalText.GetText()!.ToString() switch
                 {
                     "a" => "b",
                     var other => other
                 }))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Select((additionalText, _) => (AdditionalText)new InMemoryAdditionalText(additionalText.Path, additionalText.GetText()!.ToString() switch
                 {
                     "a" => "b",
                     var other => other
                 }))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Select((additionalText, _) => (AdditionalText)new InMemoryAdditionalText(additionalText.Path, additionalText.GetText()!.ToString() switch
                 {
                     "a" => "b",
                     var other => other
                 }))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Select((additionalText, _) => (AdditionalText)new InMemoryAdditionalText(additionalText.Path, additionalText.GetText()!.ToString() switch
                 {
                     "a" => "b",
                     var other => other
                 }))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Select((additionalText, _) => (AdditionalText)new InMemoryAdditionalText(additionalText.Path, additionalText.GetText()!.ToString() switch
                 {
                     "a" => "b",
                     var other => other
                 }))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Select((additionalText, _) => (AdditionalText)new InMemoryAdditionalText(additionalText.Path, additionalText.GetText()!.ToString() switch
                 {
                     "a" => "b",
                     var other => other
                 }))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Select((additionalText, _) => (AdditionalText)new InMemoryAdditionalText(additionalText.Path, additionalText.GetText()!.ToString() switch
                 {
                     "a" => "b",
                     var other => other
                 }))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Combine(context.AdditionalTextsProvider
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (true, true),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .SelectMany((additionalText, _) => new (bool TransformAs, bool TransformCs)[] {
                     (false, true),
                     (true, true),
                     (false, false),
                 }.Select(logic => (AdditionalText)new InMemoryAdditionalText(hintNameProvider.GetNextHintName(), additionalText.GetText()!.ToString() switch
                 {
                     "a" when logic.TransformAs => "b",
                     "c" when logic.TransformCs => "d",
                     var other => other
                 })))
                 .Select((additionalText, _) => (AdditionalText)new InMemoryAdditionalText(additionalText.Path, additionalText.GetText()!.ToString() switch
                 {
                     "a" => "b",
                     var other => other
                 }))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
                 .Collect()
                 )
                 .Select((pair, _)
                     => (AdditionalText)new InMemoryAdditionalText(
                         pair.Left.Path,
                         string.Join("", pair.Right.Select(text => text.GetText()!.ToString()))))
             ;
             context.RegisterSourceOutput(provider, (context, text) =>
             {
                 context.AddSource(text.Path, text.GetText()!.ToString());
             });
         }
     }

There is no way that a fuzzer I added like a year ago is now finding a real (but likely transient) problem..right?

src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberContainerSymbol.cs

src/Compilers/CSharp/Portable/Symbols/Source/SourcePropertySymbol.cs

RikkiGibson · 2024-09-06T22:44:09Z

src/Compilers/CSharp/Portable/Symbols/Source/SourcePropertySymbolBase.cs

+                    // When calling through the SemanticModel, partial members are not
+                    // necessarily merged when the containing type includes a primary
+                    // constructor - see https://github.com/dotnet/roslyn/issues/75002.
+                    else if (_containingType.PrimaryConstructor is { })


This feels like too direct of a workaround for a bug. Basically, it's not clear that this is the only case where we would be accessing this information before containing type members are complete.

I think if this API must work while the symbol is in this state, then it would make sense to:

Debug.Assert(_containingType.PrimaryConstructor is { }), so that we detect any test scenarios which tell us more cases where this is occurring.

Always return the same value when !_containingType.AreMembersComplete, regardless of whether _containingType.PrimaryConstructor is { }. Whether the right thing is for it to always be DeclaredAutoPropertyInfo or _lazyMergedAutoPropertyInfo!, I am not sure. It is essentially an internal error recovery scenario, for a case where the symbols are in an invalid state.

I was also wondering, did you consider using a similar pattern as we use for BoundAttributesSource/GetAttributeDeclarations? Basically make the definition part the source of truth for properties like BackingField, UsesFieldKeyword etc., digging into the implementation part symbol to obtain bits of information when the APIs are first accessed. #Resolved

src/Compilers/CSharp/Test/Emit2/Semantics/PrimaryConstructorTests.cs

src/Compilers/CSharp/Test/Emit3/FieldKeywordTests.cs

cston · 2024-09-09T20:40:30Z

@333fred, @RikkiGibson, @dotnet/roslyn-compiler, please review.

RikkiGibson · 2024-09-10T18:03:08Z

src/Compilers/CSharp/Portable/Symbols/Source/SourcePropertySymbolBase.cs

+                        // The property should only be used after members in the containing
+                        // type are complete, and partial members have been merged.
+                        return backingField;


I think we should also assert that we are in one of the scenarios which is known to have this problem (containing type has primary constructor). #Resolved

I don't think we can assert here since this is a property that might be invoked in the debugger, before containing members are complete.

Could we assert !Debugger.IsAttached?

src/Compilers/CSharp/Portable/Symbols/Source/SourcePropertySymbolBase.cs

Field-backed properties: partial properties

0ff1bbd

dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 30, 2024

cston force-pushed the partial-props branch 4 times, most recently from b0f42f7 to 45cb105 Compare September 2, 2024 21:33

cston added 2 commits September 2, 2024 15:04

Lazily calculate backing field

decfd13

Update target framework

c148b99

cston force-pushed the partial-props branch from 45cb105 to c148b99 Compare September 2, 2024 22:05

cston added 3 commits September 2, 2024 16:23

Test static

607b953

More tests

084e1b5

Misc.

60afe60

cston force-pushed the partial-props branch 2 times, most recently from 22ba653 to ae4b17a Compare September 4, 2024 03:53

Lazily set auto property data

b82b644

cston force-pushed the partial-props branch from ae4b17a to b82b644 Compare September 4, 2024 04:57

Additional verification

3978cb5

cston force-pushed the partial-props branch 2 times, most recently from a8eeabf to 28c7686 Compare September 5, 2024 03:19

Additional tests

0a8d0d3

cston force-pushed the partial-props branch from 28c7686 to 0a8d0d3 Compare September 5, 2024 05:10

cston marked this pull request as ready for review September 5, 2024 05:16

cston requested a review from a team as a code owner September 5, 2024 05:16

cston requested review from 333fred and RikkiGibson September 5, 2024 05:17

jcouv added the New Feature - Field Keyword label Sep 5, 2024

cston marked this pull request as draft September 5, 2024 16:04

cston added 2 commits September 5, 2024 09:53

Update test

81d1ac5

Update AutoPropertyData

572ec2f

Update tests

d0221dc

RikkiGibson self-assigned this Sep 6, 2024

cston added 2 commits September 6, 2024 13:52

Use property definition part for field attributes

52331d7

Update comment

891ef77

RikkiGibson reviewed Sep 6, 2024

View reviewed changes

Remove AutoPropertyInfo

266e6b7

cston force-pushed the partial-props branch from 2cdcd2b to 266e6b7 Compare September 7, 2024 18:23

cston added 9 commits September 7, 2024 12:47

Cleanup

9aba1bf

Cleanup

26b927e

Test BackingField.IsReadOnly

2e0d0c6

Cleanup

fd320e2

Consider readonly modifier on accessor

baee794

Remove stale comments

c437aa4

Update tests

45bf8f8

Verify merged property backing field

9de6785

Cleanup

c19f205

cston requested a review from a team September 9, 2024 20:40

RikkiGibson approved these changes Sep 10, 2024

View reviewed changes

Add asserts

4bbe0b3

RikkiGibson approved these changes Sep 10, 2024

View reviewed changes

333fred approved these changes Sep 10, 2024

View reviewed changes

cston merged commit 3bfa347 into dotnet:features/field-keyword Sep 10, 2024
24 checks passed

cston deleted the partial-props branch September 10, 2024 21:20

build-analysis bot mentioned this pull request Sep 11, 2024

The active test run was aborted. Reason: Test host process crashed dotnet/dnceng#451

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Field-backed properties: support partial properties with auto-implemented accessors and with initializers #74959

Field-backed properties: support partial properties with auto-implemented accessors and with initializers #74959

cston commented Aug 30, 2024

RikkiGibson commented Sep 6, 2024

RikkiGibson Sep 6, 2024 •

edited by cston

Loading

cston commented Sep 9, 2024

RikkiGibson Sep 10, 2024 •

edited by cston

Loading

cston Sep 10, 2024 •

edited

Loading

333fred Sep 10, 2024

Field-backed properties: support partial properties with auto-implemented accessors and with initializers #74959

Field-backed properties: support partial properties with auto-implemented accessors and with initializers #74959

Conversation

cston commented Aug 30, 2024

RikkiGibson commented Sep 6, 2024

RikkiGibson Sep 6, 2024 • edited by cston Loading

Choose a reason for hiding this comment

cston commented Sep 9, 2024

RikkiGibson Sep 10, 2024 • edited by cston Loading

Choose a reason for hiding this comment

cston Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

333fred Sep 10, 2024

Choose a reason for hiding this comment

RikkiGibson Sep 6, 2024 •

edited by cston

Loading

RikkiGibson Sep 10, 2024 •

edited by cston

Loading

cston Sep 10, 2024 •

edited

Loading