Fix Copilot option bug #74781
Merged
Fix Copilot option bug #74781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
Cosifne
reviewed
Aug 15, 2024
| // The bool setting is persisted as 0=None, 1=True, 2=False, so it needs to be retrieved as an int. | ||
| return settingManager.TryGetValue($"{CopilotOptionNamePrefix}.{optionName}", out int isEnabled) == GetValueResult.Success | ||
| && isEnabled == 1; | ||
| && isEnabled != 2; |
There was a problem hiding this comment.
So None and True both means enabled? Does this mean it's enabled by default?
There was a problem hiding this comment.
yea, this is now enabled by default (the source of truth is in copilot repo, where all those options are defined)
There was a problem hiding this comment.
Copilot needs an option provider service so they can apply the defaults when you request values.
There was a problem hiding this comment.
No, it was all me wishing something existed. They could write the defaults for their settings as $"{CopilotOptionNamePrefix}.{option.Name}.Default" or something similar. Then we could defer to whatever they ship.
There was a problem hiding this comment.
Why are we not using our existing options infra?
genlu
approved these changes
Aug 15, 2024
arunchndr
pushed a commit
that referenced
this pull request
Aug 16, 2024
jaredpar
pushed a commit
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where default option value was not being respected