Avoid async void methods #74744
Merged
Avoid async void methods #74744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Aug 13, 2024
| #pragma warning disable VSTHRD100 // Avoid async void methods | ||
| private async void StartRefreshingMetadataReferencesForFile(object? sender, string fullFilePath) | ||
| #pragma warning restore VSTHRD100 // Avoid async void methods | ||
| private void StartRefreshingMetadataReferencesForFile(object? sender, string fullFilePath) |
Member
Author
There was a problem hiding this comment.
view with whitespace off.
ryzngard
approved these changes
Aug 13, 2024
sharwell
approved these changes
Aug 13, 2024
| using var asyncToken = WorkspaceListener.BeginAsyncOperation(nameof(StartRefreshingMetadataReferencesForFile)); | ||
| var asyncToken = WorkspaceListener.BeginAsyncOperation(nameof(StartRefreshingMetadataReferencesForFile)); | ||
| var task = StartRefreshingMetadataReferencesForFileAsync(sender, fullFilePath); | ||
| task.CompletesAsyncOperation(asyncToken); |
Contributor
There was a problem hiding this comment.
❔ Do we want to also add a telemetry handler here?
Member
Author
There was a problem hiding this comment.
i'm ok with this as is for now. unless there's a nice easy one we can hook up.
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.