Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use manual foreach instead of AddRange method for certain collection expression spreads #74630

Merged
merged 9 commits into from
Aug 14, 2024
Merged

Use manual foreach instead of AddRange method for certain collection expression spreads #74630

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
15ce34d
Use manual `foreach` instead of `AddRange` method when collection typ…
DoctorKrolic Aug 1, 2024
08b9ea8
Tweak test name
DoctorKrolic Aug 1, 2024
0ac9d3c
Discarded use-site info
DoctorKrolic Aug 5, 2024
21d2a8f
Merge branch 'dotnet:main' into collection-expressions-use-manual-for…
DoctorKrolic Aug 6, 2024
b534c2d
Move down
DoctorKrolic Aug 14, 2024
67fce6e
Use collection expression extensions without span
DoctorKrolic Aug 14, 2024
07ac41e
Verify for multiple target frameworks
DoctorKrolic Aug 14, 2024
ea78e18
Conditionaly include output
DoctorKrolic Aug 14, 2024
bb56e4e
Simplify
DoctorKrolic Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions src/Compilers/CSharp/Test/Emit2/Semantics/CollectionExpressionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34722,7 +34722,18 @@ static void Main()
}
""";
DoctorKrolic marked this conversation as resolved.
Show resolved Hide resolved

var verifier = CompileAndVerify([source, s_collectionExtensions], expectedOutput: "[1, 2, 3],", targetFramework: targetFramework, verify: Verification.Skipped);
var expectedOutputString = "[1, 2, 3],";
DoctorKrolic marked this conversation as resolved.
Show resolved Hide resolved
var verifier = CompileAndVerify(
[source, s_collectionExtensions],
expectedOutput: targetFramework switch
DoctorKrolic marked this conversation as resolved.
Show resolved Hide resolved
{
TargetFramework.Net80 => IncludeExpectedOutput(expectedOutputString),
TargetFramework.Standard => expectedOutputString,
_ => throw new InvalidOperationException("Update expected output!"),
},
targetFramework: targetFramework,
verify: Verification.Skipped);

verifier.VerifyDiagnostics();

switch (targetFramework)
Expand Down Expand Up @@ -34806,6 +34817,8 @@ .locals init (MyCollection V_0)
}
""");
break;
default:
throw new InvalidOperationException("Update verified IL!");
}
}

Expand Down Expand Up @@ -35117,7 +35130,18 @@ static void Main()
}
""";

var verifier = CompileAndVerify([source, s_collectionExtensions], expectedOutput: "[1, 2, 3],", targetFramework: targetFramework, verify: Verification.Skipped);
var expectedOutputString = "[1, 2, 3],";
var verifier = CompileAndVerify(
[source, s_collectionExtensions],
expectedOutput: targetFramework switch
{
TargetFramework.Net80 => IncludeExpectedOutput(expectedOutputString),
TargetFramework.Standard => expectedOutputString,
_ => throw new InvalidOperationException("Update expected output!"),
},
targetFramework: targetFramework,
verify: Verification.Skipped);

verifier.VerifyDiagnostics();

switch (targetFramework)
Expand Down Expand Up @@ -35200,6 +35224,8 @@ .locals init (MyCollection V_0)
}
""");
break;
default:
throw new InvalidOperationException("Update verified IL!");
}
}

Expand Down
Loading