Automatically tag PRs which may affect the C# extension. #74590
Conversation
ghost
added
Area-Infrastructure
untriaged
| label: Community | ||
| description: Label Community Pull Requests | ||
| triggerOnOwnActions: false | ||
| - if: |
There was a problem hiding this comment.
Does this actually work? I've not see the equivalent API Owners tagging actually work well.
There was a problem hiding this comment.
I have no idea. I based it on the other PR taggers, but am not sure there is a good way to test.
There was a problem hiding this comment.
Looking at docs and I think the indentation is all wrong. Will update.
There was a problem hiding this comment.
Doesn't look like the formatting was that different after all. Still made changes to improve readability.
dibarbet
left a comment
dibarbet
left a comment
There was a problem hiding this comment.
I'm fine with this. But definitely should get thoughts from other @dotnet/roslyn-infrastructure folks
| configuration: | ||
| resourceManagementConfiguration: | ||
| scheduledSearches: | ||
|
|
There was a problem hiding this comment.
Added empty line between searches and tasks
| - description: Auto-approve auto-merge PRs | ||
| triggerOnOwnActions: false |
There was a problem hiding this comment.
Moved description and trigger to the top of each task to improve readability
| - if: | ||
| if: | ||
| - payloadType: Pull_Request | ||
| - isPullRequest |
There was a problem hiding this comment.
Added isPullRequest filter where applicable
|
Gonna get this merged so that I can test it. If the tagging doesn't work then it is an easy revert. |
It can be tedious to determine what changes in Roslyn are relevant to the C# extension. The idea is that changes under these folders may change the behavior of the Roslyn LSP and thus impact the C# extension. PR authors may remove the label if they do not believe their change is impactful.