Rename Suggestions: Fix getting of the context string, gracefully handle errors #74564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
the
Community
AmadeusW
commented
Jul 25, 2024
src/EditorFeatures/Core.Wpf/InlineRename/UI/SmartRename/SmartRenameViewModel.cs
Show resolved
Hide resolved
Cosifne
reviewed
Jul 26, 2024
| startPosition = documentText.Lines[startLine].Start; | ||
| endPosition = documentText.Lines[endLine].End; | ||
| var length = endPosition - startPosition + 1; | ||
| var length = endPosition - startPosition; |
There was a problem hiding this comment.
🤔Do you feel it needs to be covered by a test?
either integration test(is querying copilot in CI allowed?)/unit test (might be lighter, and assert GetRenameContextAsync directly, but we might need to hard-code the result in test)
There was a problem hiding this comment.
Definitely. We synced over message, @Cosifne is helping set up the test
Cosifne
approved these changes
Jul 30, 2024
Open
3 tasks
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an edge case in code that gets context (references, definitions) for copilot rename suggestions.
When a reference/definition touched the end of file (because there was no empty line at the end of file),
ArgumentOutOfRangeExceptionwas thrown from withinGetRenameContextAsync, and Roslyn ended up not making the rename request at all.The solution is twofold:
\ron Windows machines (and therefore not visible in logs).Fixes #74545 and DevDiv 2173894