Reduce allocations in SymbolKey.ResolveString #74513
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Compilers
untriaged
| /// <summary> | ||
| /// Get all the members of this symbol that have a particular name. | ||
| /// </summary> | ||
| void GetMembers<TArg>(string name, Action<INamespaceOrTypeSymbol, TArg> callback, TArg argument); |
There was a problem hiding this comment.
i don't have an issue with this. but my guess is that we need to be consistent with this and the other cases of Getmembers we have. want to extract out and bring to API review?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2136177
Note that much of the overhead in this implementation stems from the use of
ignoreAssemblyKey: truehere:roslyn/src/Workspaces/Core/Portable/FindSymbols/SymbolFinder.cs
Line 193 in 2cd12e8
If symbol resolution with
ignoreAssemblyKey: falseworked here frequently enough that it would be acceptable to always try it first and only fall back toignoreAssemblyKey: trueon failure, this method could be significantly improved.