Skip to content

EnC: Implement support for partial properties #74494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 29, 2024
Merged

EnC: Implement support for partial properties #74494

merged 4 commits into from
Jul 29, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 23, 2024 •
edited by jcouv
Loading

Contributes to #73772
Relates to test plan #73090

@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 23, 2024
@tmat tmat marked this pull request as ready for review July 23, 2024 04:13
@tmat tmat requested review from a team as code owners July 23, 2024 04:13
@tmat
Copy link
Member Author

tmat commented Jul 23, 2024

@davidwengier PTAL

@tmat
Copy link
Member Author

tmat commented Jul 23, 2024 •
edited
Loading

@jjonescz @cston @dotnet/roslyn-compiler ptal

@RikkiGibson RikkiGibson self-requested a review July 23, 2024 04:27
davidwengier
davidwengier approved these changes Jul 23, 2024
View reviewed changes
jjonescz
jjonescz approved these changes Jul 23, 2024
View reviewed changes
@jaredpar
Copy link
Member

@RikkiGibson for second sign off here.

RikkiGibson
RikkiGibson reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take a look today

RikkiGibson
RikkiGibson approved these changes Jul 26, 2024
View reviewed changes
@tmat tmat enabled auto-merge (squash) July 29, 2024 15:36
@tmat tmat merged commit 52e29db into dotnet:main Jul 29, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 29, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
@dotnet-bot dotnet-bot mentioned this pull request Jul 31, 2024
Closed
@tmat tmat deleted the EncPartialProps branch July 31, 2024 14:49
@dotnet-bot dotnet-bot mentioned this pull request Aug 2, 2024
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
@tmat tmat mentioned this pull request Sep 14, 2024
Open
11 tasks
@jcouv jcouv mentioned this pull request Sep 15, 2024
Closed
39 tasks
@jjonescz jjonescz mentioned this pull request Feb 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

@jjonescz jjonescz jjonescz approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

Assignees

@RikkiGibson RikkiGibson

Labels
Area-Compilers Feature - Partial Properties untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.12 P1
Development

Successfully merging this pull request may close these issues.
6 participants
@tmat @jaredpar @davidwengier @jjonescz @RikkiGibson @jcouv