Adds support for metadata LSP language features in VSCode #74488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
dibarbet
commented
Jul 22, 2024
src/Features/Core/Portable/MetadataAsSource/DecompilationMetadataAsSourceFileProvider.cs
Show resolved
Hide resolved
This was referenced Jul 23, 2024
src/Features/Core/Portable/MetadataAsSource/DecompilationMetadataAsSourceFileProvider.cs
Show resolved
Hide resolved
src/Features/Core/Portable/MetadataAsSource/IMetadataAsSourceFileProvider.cs
Outdated
Show resolved
Hide resolved
| // add the LspMiscellaneousFilesWorkspace for hosts that have not already brought their own. | ||
| if (serverKind == WellKnownLspServerKinds.CSharpVisualBasicLspServer) | ||
| AddLazyService<LspMiscellaneousFilesWorkspace>(lspServices => new LspMiscellaneousFilesWorkspace(lspServices, hostServices)); | ||
| AddLazyService<LspMiscellaneousFilesWorkspace>(lspServices => lspServices.GetRequiredService<LspMiscellaneousFilesWorkspaceProvider>().CreateLspMiscellaneousFilesWorkspace(lspServices, hostServices)); |
Member
Author
There was a problem hiding this comment.
The misc files workspace now requires dependencies from both regular mef (IMetadataAsSourceFileService) and directly from the base language server instance (HostServices) that aren't available as MEF services.
So the provider can import the MEF service normally, then gets passed in the HostServices by the instance.
src/LanguageServer/Protocol/Workspaces/LspMiscellaneousFilesWorkspaceProvider.cs
Outdated
Show resolved
Hide resolved
src/LanguageServer/Protocol/Workspaces/LspMiscellaneousFilesWorkspace.cs
Outdated
Show resolved
Hide resolved
src/LanguageServer/ProtocolUnitTests/Metadata/LspMetadataAsSourceWorkspaceTests.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Jul 23, 2024
Member
CyrusNajmabadi
left a comment
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
overall ok. i do think locking of some form would be good.
CyrusNajmabadi
approved these changes
Jul 23, 2024
JoeRobich
approved these changes
Jul 23, 2024
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves dotnet/vscode-csharp#5787
In VS, the VS misc workspace delegates to the MetadataAsSource workspace to open the file if it recognizes a metadata file. This was not happening in VSCode because we do not use the VS misc workspace. So files would get generated, but never added to the MetadataAsSource workspace.
Instead, I added similar functionality to the LSP misc files workspace (to add/remove from MetadataAsSource if a metadata file is opened/closed).