Include wrapping options in editorconfig formatting options #73938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
Member
Author
|
@CyrusNajmabadi @sharwell @dotnet/roslyn-ide |
Contributor
|
What about |
Member
Author
We can certainly use such prefix. |
src/Analyzers/CSharp/CodeFixes/UseCollectionExpression/CSharpCollectionExpressionRewriter.cs
Outdated
Show resolved
Hide resolved
...s/Core/CodeFixes/UseConditionalExpression/AbstractUseConditionalExpressionCodeFixProvider.cs
Show resolved
Hide resolved
src/Workspaces/CSharp/Portable/Options/CSharpEditorConfigOptionsEnumerator.cs
Outdated
Show resolved
Hide resolved
| /// Internal option -- not exposed to editorconfig tooling via <see cref="EditorConfigOptions"/>. | ||
| /// </summary> | ||
| public static readonly Option2<int> CollectionExpressionWrappingLength = new( | ||
| $"csharp_internal_collection_expression_wrapping_length", |
Member
There was a problem hiding this comment.
What actually stops it from being exposed?
Member
Author
There was a problem hiding this comment.
What do you mean "exposed"? Not able to use it in editorconfig file?
...ces/SharedUtilitiesAndExtensions/Compiler/CSharp/Formatting/CSharpSyntaxFormattingOptions.cs
Show resolved
Hide resolved
Member
|
|
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
CyrusNajmabadi
approved these changes
Jun 13, 2024
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping options
dotnet_internal_wrapping_columndotnet_internal_conditional_expression_wrapping_lengthcsharp_internal_collection_expression_wrapping_lengthare currently only available from global options. They are only set by tests at this moment. We do not allow the user to change the values via Tools > Options or editorconfig. See #30422 (comment).
These options are read from analyzers and the code doing so is different between features and code style.
This change unifies the code by making these options undocumented editorconfig options. This means that tooling such as editorconfig generator, Tools > Options UI, etc. won't generate/display these options but the options will be available via
AnalyzerConfigOptionsto analyzers. Setting these in a proper editorconfig file will work, but is not officially supported. In future, once #30422 (comment) is resolved, we may decide to make these options official.Ultimately, the goal is for all options used by analyzers that are currently only available from global options to be converted to (ndocumented) editorconfig options.
Possible follow-up:
SyntaxWrappingOptionsintoSyntaxFormattingOptions-- it doesn't seem worth having separate types for wrapping operations as they also reference formatting options.