Skip to content

Conversation

sharwell
Copy link
Contributor

@sharwell sharwell commented Jun 4, 2024

  • Use built-in features for marking unnecessary code
  • Verify missing code style severity falls back to old behavior
  • Use EnableCodeStyleSeverity instead of AnalysisLevel to control new diagnostic severity behavior

Follow-up to #72238

@sharwell sharwell requested a review from a team as a code owner June 4, 2024 18:24
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 4, 2024
@sharwell sharwell changed the title Custom severity Expand testing for code style severity settings Jun 4, 2024
@sharwell sharwell changed the title Expand testing for code style severity settings Use EnableCodeStyleSeverity instead of AnalysisLevel to control new diagnostic severity behavior Jun 4, 2024
@cremor
Copy link

cremor commented Jun 5, 2024

@sharwell
Copy link
Contributor Author

sharwell commented Jun 5, 2024

Yes, those would need to be updated. We'll also need to update the SDK code style build targets to feed the new build property to the compiler.

@arunchndr arunchndr requested a review from jaredpar July 16, 2024 17:41
[Trait(Traits.Feature, Traits.Features.CodeActionsUseObjectInitializer)]
public partial class UseObjectInitializerTests
{
private static async Task TestInRegularAndScriptAsync(string testCode, string fixedCode, OutputKind outputKind = OutputKind.DynamicallyLinkedLibrary)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this change produce so much churn in the object init tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This analyzer was using an old strategy for code fading that was interfering with some new testing we needed for the feature change. I converted the analyzer to the new style as a separate commit at the beginning of this PR.

@RikkiGibson RikkiGibson self-assigned this Aug 12, 2024
@sharwell
Copy link
Contributor Author

Rebased after reviews completed to apply the fixup commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants