Skip to content

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Jun 3, 2024

Diagnostics for TS diagnostics in Razor files should only ever come from Razor, not through Roslyn, so we avoid reporting them.

This is a workaround for 17.10 that will be removed in 17.11 (we no longer report TS diagnostics through roslyn in 17.11).

image

@dibarbet dibarbet requested a review from a team as a code owner June 3, 2024 23:32
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 3, 2024
@dibarbet dibarbet enabled auto-merge June 4, 2024 00:30
@dibarbet dibarbet merged commit d6adff2 into dotnet:release/dev17.10 Jun 4, 2024
@dibarbet dibarbet deleted the typescript_workspace_diag_workaround branch June 4, 2024 00:56
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants